Files

73 lines
7.3 KiB
Markdown

# P05-CI-01 - Gitea Actions Verification Foundation
Date: 2026-11-22
Status: SOURCE IMPLEMENTED; ONE CI RUN COMPLETED WITH BLOCKERS; NOT PRODUCTION-ACCEPTED
Baseline: `7ecf53169776cc7f08af3dde6fe4b4492acf3ea1` (local and Gitea `main` matched before implementation)
User approval: 2026-11-22 P05-CI-01 explicit instruction. One focused Gitea Actions acceptance cycle, Git commit/push; **no local tests/builds/dev services**.
## Exact write scope
- `.gitea/**` - new workflow plus README/MINIFEST for first-party directories
- `tests/ci/**` - isolated runner verification utilities and folder docs
- `users/ui/package.json` and `users/ui/package-lock.json` - only justified dependency/lock corrections
- `auth/ui/v2/pnpm-workspace.yaml` and `auth/ui/v2/pnpm-lock.yaml` - only slim workspace reconciliation
- `notes/**`, `project/**`, relevant `docs/**`, `README.md` - evidence, manifests and documentation
- Existing `tests/README.md` is **not** approved for write; document test folder in its nested `tests/ci/` instead.
- `deployment/docker/compose.backend.dev.yaml` and `core/backend/zitadel/dev.py` remain **read-only**. Any reproduced runtime bug here requires a separate approved exception.
Excluded: application Login V2 source logic, account portal auth/session/pages, UI redesign, production deployment, release/tag, real credentials, production data, local build/test, unrelated untracked `AI_INSTRUCTIONS.md`.
## Pre-change root cause evidence
1. Gitea `vibtools/ZitPlane`: Actions enabled but **0 workflows**. Existing Gitea runner success in the sister repo DataStack on `ubuntu-latest` for CLI/Docker workflows; ZitPlane runner capability still must be checked on its own run.
2. P03 slim Login source: root `auth/ui/v2/pnpm-workspace.yaml` still references upstream `console`, `tests/*`, `deploy/compose` etc; only `apps/login`, `packages/zitadel-client`, `packages/zitadel-proto` imported. Original `pnpm-lock.yaml` contains absent importers (`apps/docs` etc), likely requires lockfile-safe reconciliation.
3. `auth/ui/v2/apps/login/project.json` declares build dependencies on generated proto and client; explicit reproducible install/build/verification must preserve this dependency graph.
4. `users/ui/package.json` pins Next/React/Auth.js and lacks `package-lock.json`; CI cannot use `npm ci` until a reviewed lockfile exists.
5. P02 dev Compose defines PostgreSQL, official ZITADEL API, prebuilt Login V2 and Traefik; **Docker/health/SSO not previously tested**.
6. P04 Auth.js OIDC route, session expiry, protected pages, local-only sign-out are **source-only**, not integrated with a disposable ZITADEL instance. Avoid simulated PASS or real-user tokens.
## Execution plan
A. Create first-party `.gitea/`, `.gitea/workflows/`, `tests/ci/` README/MINIFEST files and single manually dispatched `p05-ci.yml` with a preflight gate, account reproducible build, Login V2 frozen build, targeted dependency triage, disposable backend smoke and optional OIDC acceptance with explicit prerequisites.
B. Reconcile only necessary workspace/lockfile inputs. Lockfiles are generated **without executing local builds/tests**. Any unsupported reproducibility or failed generation must become a clear BLOCKED condition, not a silent unlocked install.
C. Runner job uses transient secrets, loopback-only services, disposable Docker Compose project/volumes, and always cleanup; never touches live ZITADEL domains or production data.
D. Stage exact paths, audit source scope and sensitive files, commit locally, push `main`; dispatch **one** workflow run; read run/jobs/log evidence and document exact results/remaining blockers.
E. Final evidence, notes/project/docs/manifests synchronized. If CI fails, record failure and propose a new phase/scope instead of unlimited edit/retry loops.
## Acceptance policy
Only call a gate PASS if real Gitea Actions job step succeeded. Docker/OIDC requiring missing capability must state BLOCKED. No production-ready claim until all required gates succeed. Version/security advisories: report exact package/version/severity/decision; do not apply blind dependency updates.
## Actual implementation and one-cycle Gitea result (2026-11-22)
**Initial pushed CI source SHA:** `42b79362c13b9dbb07f85a58ad278742d91b1f5b`.
**Run:** [Gitea Actions #81](https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/81), event `workflow_dispatch` on `main`; started 12:59:03Z, completed 13:03:55Z; **overall FAILURE**.
| Job | ID | Actual result | Concrete evidence |
| --- | ---: | --- | --- |
| Account Portal | 165 | **FAIL** | Checkout + source/lock/guard preflight PASS; `npm ci` added 38 packages. `npm run typecheck` TS2345 `users/ui/src/auth.ts(14,61)`: Auth.js session callback's inferred `user.id` type is not assignable to `string`. Next build not run |
| Login V2 | 166 | **PASS** | `pnpm install --frozen-lockfile` PASS; Nx generated proto + built client and Login V2 standalone PASS; upstream Vitest 84/84 files and **1219/1219 tests PASS** |
| Dependency advisory | 167 | **PASS only for HIGH/CRITICAL gate** | `npm audit --omit=dev --audit-level=high` PASS; `pnpm audit --prod --audit-level high` PASS; **18 MODERATE** Login advisory findings remain open, exact packages/remediation not yet triaged |
| Disposable Docker | 168 | **FAIL before Docker** | `node:22-alpine` checkout had no Git, falling back to REST archive which returned `Not found` after retries. Docker setup, P02 Python tests, backend runtime, ready/discovery/JWKS NOT RUN; always-cleanup step PASS |
**One focused CI acceptance cycle only.** No rerun, no local tests/builds/dev server/Docker. No actual user session, MFA, Admin Console or production deployment was verified.
### Exact in-scope source remediation (after Run #81)
`.gitea/workflows/p05-ci.yml`: inserted `apk add --no-cache git` **before** `actions/checkout@v4` in Alpine backend job. This fixes the identified checkout prerequisite **in source**, but **has not been CI-tested**. No changes to `core/backend/zitadel/`, `deployment/docker/`, `users/ui/src/auth.ts`, Login V2 original application code, or unrelated files.
### Open blockers and disposition
- **P05-B01 / Account Auth.js TS2345:** needs narrowly approved `users/ui/src/auth.ts` / type augmentation patch, preserve existing expiry/identity guarantees and regression test. Out of P05 write scope, **do not patch here**.
- **P05-B02 / Docker runtime acceptance:** first run did not reach Docker preflight. Corrected checkout source needs a separately approved Gitea CI rerun; no claim of ZITADEL health, Admin Console, persistence or OIDC discovery.
- **P05-B03 / Moderate advisories:** 18 moderate findings from `pnpm audit --prod`; current high/critical gate passed, but package-level advisory IDs and real impact must be collected and triaged before production.
- **P05-B04 / Interactive OIDC:** no disposable confidential OIDC client/user lifecycle harness in P05; full Account Portal auth callback, MFA/passkey, logout and protected route E2E remain **unverified**.
- All existing production host/domain/DNS/Coolify and real data unchanged.
**Final status:** Source and Gitea Actions foundation implemented and audited; **full CI acceptance BLOCKED**. Follow-up must be a separately approved, exact-scope remediation. After the result documentation and CI-only checkout patch are committed and pushed, record the new exact `main` SHA via Git; **that new SHA is not the tested Run #81 SHA**.