docs(ci): record run 88 and narrow transitive override parser

This commit is contained in:
victorsteele428 committed 2026-11-22 14:40:05 +00:00
1 parent 66cfed5a8b
commit 7655dbdcb4
20 files changed
+67 -16

No files matched your search

+1 -1
View File
@@ -13,7 +13,7 @@ This is the **developer-focused implementation history**. `notes/CHANGELOG.md` i
| 2026-11-22 | P05-CI-02 | Type-safe Auth.js subject narrowing, Account anonymous negative tests, Login regression, structured advisory triage and CI-only portless Docker override | Run #83: 3 PASS/1 FAIL; Docker proxy 8080 collision, cleanup PASS, portless fix unverified; see `notes/P05-CI-02.md` |
| 2026-11-22 | P05-CI-03 | Dedicated manual backend-only CI acceptance, guarded disposable Compose, persistence/ready/JWKS probes and owned-state cleanup | **Gitea Run #86 SUCCESS** on `03fb589`; all steps PASS; `notes/P05-CI-03.md` |
| 2026-11-22 | P05-SEC-01 | Next.js/OTel minimal security manifests, reproducible locks, dedicated CI and strict Moderate+ gates | Run #87: Account/Login build PASS, Login Vitest 1219/1219, Account audit 0, Login 2 Moderate open; `notes/P05-SEC-01.md` |
| 2026-11-22 | P05-SEC-02 | Seven parent-targeted glob/minimatch patched resolutions, PNPM lockfile metadata-only and manual Login-only CI guard | Run pending; `notes/P05-SEC-02.md`, `project/DEPENDENCY-SECURITY.md` |
| 2026-11-22 | P05-SEC-02 | Seven parent-targeted glob/minimatch patched resolutions, PNPM lockfile metadata-only, manual Login-only CI and post-run validator fix | Run #88: strict Login audit 0 findings PASS, Login build job blocked before install by parser false-positive; post-run fix untested. `notes/P05-SEC-02.md` |
## Required entry for each future change
+5
View File
@@ -105,3 +105,8 @@ Existing manual `.gitea/workflows/p05-security-acceptance.yml` now offers `workf
`login` starts with CI-only `python3 ../../../tests/ci/transitive_override_contract.py` for the exact seven owned parent overrides and no affected glob/minimatch lock versions, then pinned PNPM frozen install, upstream proto/client/Login standalone build and full `vitest --run` regressions. `security_login` uses existing production PNPM HIGH/CRITICAL audit and independent JSON detail + zero Moderate+ gate; **no suppression**. Both jobs must conclude SUCCESS before declaring P05-SEC-02 accepted. The historical Account zero-vulnerability proof is Gitea Run #87, **not retested** in this focused phase.
A single manual run is authorized; Git source commit/push precedes dispatch, and final evidence-only documentation commit/push follows without a second run. Source-only audit and actual runner results are distinct; see `notes/P05-SEC-02.md` and `docs/P05-SEC-02.md`.
## Run #88 and CI helper parsing defect — acceptance remains blocked
Gitea Run #88 source `66cfed5`, exact tree `9a1d2abd`, intentionally skipped Account jobs #189/#191. Login security #192 **PASS** (zero Moderate/High/Critical). Login build #190 **FAIL before frozen install** in `transitive_override_contract.py` due misclassification of existing `>=` version-range keys as parent-scoped overrides. Build/unit steps were **skipped**, not failed application regressions. Narrow post-run regex correction now explicitly accepts only `>glob` / `>minimatch`; **unverified until a newly approved run**. One focused run only; follow-up P05-SEC-02-A01 should run *only* Login frozen/build/unit with security gate, under a separately approved baseline.
+11
View File
@@ -66,3 +66,14 @@ Selected exact patch pins `glob@14.0.6` and `minimatch@11.0.9` are **published**
The seven *semver-major transitive* substitutions require runtime compatibility proofs. `tests/ci/transitive_override_contract.py` checks exact selector ownership, absence of vulnerable lock versions, unchanged importer requirements and the seven parent→version resolutions; it is CI-only. Manual Gitea security workflow option `login_only=true` skips previously accepted Account jobs, executes Login frozen install/build/upstream unit suite and a **strict zero Moderate/High/Critical** live production registry audit. Leave original Login auth, Account Portal, backend, deployment and unrelated package manifests read-only. Source presence is not a production-security guarantee.
**Security acceptance:** PENDING the one focused Gitea run. If registry audit or upstream regression fails, document exact blocker rather than suppressing findings or silently changing major versions.
## P05-SEC-02 Gitea Run #88 outcome (2026-11-22)
**Actual tested remote source:** `66cfed5a8b6bd5845b229c9934695e307f9a0775`, remote tree `9a1d2abd803f20cd05e428541483c1fa390e14d9` matched the local 25-file approved source commit tree byte-for-byte. One manual `login_only=true` Gitea Run [#88](https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/88), overall **FAILURE**, two Account jobs skipped as intended.
**Login production security job #192 PASS:** real registry `pnpm audit --prod` reported `No known vulnerabilities found`, exactly `moderate=0, high=0, critical=0` and `ZITPLANE_PNPM_ZERO_MODERATE_HIGH_CRITICAL_PASS`. Both `glob` and `minimatch` prior Moderate findings no longer reproduce in this lock-based production audit. Previous Account registry audit was 0 in Run #87 (not rerun).
**Login frozen/build/unit job #190 FAIL before install:** newly written `tests/ci/transitive_override_contract.py` treated historical `axios@>=1.0.0`, `brace-expansion@>=4.0.0`, and `esbuild@>=0.27.3` version-range selectors as new parent overrides because the regex matched any `>`. That is a **validator false-positive**; it does **not** establish pinned PNPM frozen install or Nx/Next/1219-unit compatibility with the semver-major overrides. The helper regex was then narrowed to match **only terminal `>glob` / `>minimatch` selectors**. This final narrow correction has **NOT been executed in CI**, and there was no second run.
**Verdict:** advisory clearance **VERIFIED** in Run #88; full dependency compatibility/phase acceptance **BLOCKED** pending **P05-SEC-02-A01** isolated Login frozen install, production build, upstream unit suite, exact contract and retained zero-advisory gate. No authentication/UI/backend/Account source change or production deployment. Do not assert that historical Run #87's successful builds validate the newly overridden glob/minimatch majors.
+3
View File
@@ -116,3 +116,6 @@ Workflow shell commands are written directly under `.gitea/workflows/p05-securit
`tests/ci/transitive_override_contract.py::main()` reads the existing `auth/ui/v2/pnpm-workspace.yaml` and resolved `pnpm-lock.yaml` (no network or side effects), verifies exactly seven parent-specific override selectors, checks the four required PNPM importers, rejects any known affected glob (>=9 <=14.0.1) or minimatch (>=7 <11.0.1) snapshot, and asserts that all seven parent dependencies resolve to the exact patched version. Failure returns nonzero in CI; it does not hide audit failures or alter dependencies.
Existing `tests/ci/security_advisory_gate.py` remains the independent **live registry report** gate, rejecting malformed reports and any Moderate/High/Critical finding. A clean lockfile alone cannot prove that the live advisory audit passes.
**P05-SEC-02 post-run correction:** `overridden(data)` in `tests/ci/transitive_override_contract.py` originally matched every `>`, incorrectly interpreting `axios@>=...`, `brace-expansion@>=...` and `esbuild@>=...` existing PNPM version constraints as new parent-child override selectors. The matching expression now restricts the suffix to `>glob` or `>minimatch` only, preserving the seven exact patch-parent check without changing registry audit logic. Run #88 predates the fix; this parser has **not yet passed CI**. Auth/session flows untouched.
+3
View File
@@ -73,3 +73,6 @@ Run #86 on commit `03fb589` executed a backend-only manual Gitea Actions job and
Pre-change source and registry metadata identified two direct `glob@10.5.0` parents and five direct `minimatch@10.2.5/10.2.6` parents. The seven *parent-specific* root workspace overrides point to published `glob@14.0.6` and `minimatch@11.0.9` (Node 22 supported). Pinned PNPM `10.30.3 install --lockfile-only --ignore-scripts --no-frozen-lockfile` generated only lock metadata without app installation/build/tests. `glob@14` now depends on patched `minimatch@11`; `minimatch@3/5` are unaffected by the reported GHSA version ranges.
These are **major** dependency migrations underneath older parents, not an upstream source edit. Only a green Gitea Login Nx production build and upstream unit tests, frozen PNPM install and registry audit can certify compatibility and advisory clearance. The existing security workflow has a manual `login_only=true` focused mode; previously accepted Account results remain from Run #87.
**P05-SEC-02 actual acceptance boundary:** Run #88 `pnpm audit --prod` found **0 known Moderate/High/Critical advisories** for the 7 scoped patched parent resolutions. But new CI helper matching `>=` as parent override stopped Login frozen install before any app build/unit case ran. Post-run regex fix to recognize only `>glob` and `>minimatch` is **not CI-verified**. The dependency migration is not yet production-accepted. Do not run local app builds/tests or silently replace the pinned PNPM lock; use separately approved Login-only Gitea acceptance.
+1 -1
View File
@@ -1,6 +1,6 @@
# Git-tracked source inventory ? exact paths
**Snapshot:** 2026-11-22, P05-SEC-02 source preparation from approved baseline `43eee54`. **The focused Gitea SEC-02 CI has not yet run.**
**Snapshot:** 2026-11-22, P05-SEC-02 Git-tracked source inventory. Gitea Run #88 tested remote commit `66cfed5`, found zero Login Moderate/High/Critical advisories but build job stopped on new CI helper false-positive. Post-run parser fix is **not CI-verified**; final docs/source SHA differs from tested Run #88 SHA.
**Git-tracked paths: 732.** Untracked `AI_INSTRUCTIONS.md` and ignored secrets excluded.