docs(ci): record run 88 and narrow transitive override parser
This commit is contained in:
1 parent
66cfed5a8b
commit
7655dbdcb4
20 files changed
+67
-16
No files matched your search
@@ -10,7 +10,7 @@ Job responsibilities:
|
||||
|
||||
**P05-CI-02 additions:** Account Portal CI negative route/API smoke, npm/pnpm structured Moderate advisory detail, and disposable Postgres restart persistence plus stronger OIDC issuer/JWKS negative checks. Run #83 passed Account, Login V2 and Security jobs but backend proxy bind to shared host port 8080 failed after Postgres/ZITADEL/Login healthy. **Post-run source fix:** all backend Compose calls include `tests/ci/compose.portless.override.yaml` (`ports: !reset []`), config rejects any published proxy port; this is not CI-verified. Full authenticated user sign-in/MFA remains deferred.
|
||||
|
||||
**P05-SEC-02:** Existing `p05-security-acceptance.yml` has manual `login_only=true` option to skip the previously accepted Account jobs, run only Login V2 pinned frozen install, proto/client/standalone production build, upstream Vitest and independent **strict zero Moderate/High/Critical** live production audit. The new `tests/ci/transitive_override_contract.py` checks exactly seven known patched parent resolutions before frozen installation. Default `login_only=false` preserves earlier full workflow. Pending actual Gitea acceptance; no production. See `docs/P05-SEC-02.md`.
|
||||
**P05-SEC-02:** Existing `p05-security-acceptance.yml` manual `login_only=true` correctly SKIPPED Account jobs in **Run #88**. Login production audit PASS with **0 Moderate/High/Critical**, but new CI contract helper falsely matched `>=` ranges and blocked the separate Login frozen/build/unit job *before install*. After Run #88, parser narrowed to exact `>glob`/`>minimatch` selectors; **not CI-verified**. Default `login_only=false` still preserves the full Account/Login workflow. No second P05-SEC-02 run or production deployment. See `docs/P05-SEC-02.md`.
|
||||
|
||||
**P05-SEC-01:** `.gitea/workflows/p05-security-acceptance.yml` is **manual-only** with independent Account frozen build + negative access regressions, Login frozen Nx build + Vitest, Account production audit and Login production audit. **Run #87:** Account build, Login build/1219 unit tests, Account security audit **PASS**; Login audit **FAIL** on 2 Moderate transitive `glob`/`minimatch` findings (0 High/Critical) as required by strict `tests/ci/security_advisory_gate.py`. No source auth changes or production deployment. See `docs/P05-SEC-01.md`.
|
||||
|
||||
|
||||
@@ -11,7 +11,7 @@ Compact, developer-friendly monorepo for a central identity service, a branded l
|
||||
- **P05-CI-02:** Gitea Run #83 **3 PASS / 1 FAIL**. Account Portal typecheck/build and negative identity checks PASS; Login V2 build + 1219/1219 tests PASS; High/Critical security threshold PASS (18 Moderate Login records + 1 Moderate Account package OPEN). Docker Postgres/ZITADEL API/Login healthy, but shared runner port 8080 blocked Traefik; cleanup PASS. CI-only portless override added afterward **not CI-verified**; full OIDC E2E deferred. See `docs/P05-CI-02.md`.
|
||||
- **P05-CI-03:** **Gitea Run #86 SUCCESS** on `03fb589`: portless Docker Compose, four healthy/running services, PostgreSQL restart persistence, ZITADEL readiness, OIDC discovery/JWKS, negative contracts and complete CI cleanup verified. No repeated Account/Login suites. Full interactive OIDC E2E and Moderate dependency fixes remain pending. See `docs/P05-CI-03.md`.
|
||||
- **P05-SEC-01:** Gitea Run #87 **3 PASS / 1 FAIL**. Account and Login patched Next.js `16.4.6` builds PASS, Login 1219/1219 upstream unit tests PASS, Account audit 0. Login OpenTelemetry patched dependencies reduced prior 18 Moderate to **2 remaining** (glob/minimatch); strict Moderate security gate correctly FAILS. Current dependency patch retained; complete security acceptance requires a separate narrow transitive remediation phase. See `docs/P05-SEC-01.md`.
|
||||
- **P05-SEC-02:** Exactly seven PNPM parent-scoped overrides to remediate final `glob`/`minimatch` Moderate findings; regenerated pinned lockfile metadata without local builds/tests. Existing Login security workflow supports focused `login_only=true` Gitea CI; **acceptance pending actual CI**. See `docs/P05-SEC-02.md`.
|
||||
- **P05-SEC-02:** Seven parent-scoped PNPM overrides resolved `glob`/`minimatch` advisories. Gitea Run #88 Login production audit **0 Moderate/High/Critical PASS**, but Login frozen install/build/units **NOT RUN** because a new CI override validator misparsed existing `>=` version ranges; post-run regex correction **not CI-verified**. Full acceptance **BLOCKED** pending a separately approved focused CI run. Account jobs intentionally skipped. See `docs/P05-SEC-02.md`.
|
||||
- **Production / Coolify:** not configured or deployed.
|
||||
|
||||
## Documentation and project knowledge
|
||||
|
||||
@@ -18,7 +18,7 @@ Snapshot: 2026-11-22, **Gitea P05-CI-03 Run #86 backend-only SUCCESS** on `03fb5
|
||||
| Global ZITADEL SSO logout | No | N/A | No |
|
||||
| Subscriptions, payments and SaaS billing | Outside ZitPlane scope | N/A | No |
|
||||
| Gitea Actions CI verification workflow | Yes, P05 manual dispatch | Run #83 baseline, Run #86 backend SUCCESS, Run #87 3 PASS/1 FAIL (2 Moderate Login advisories) | Not deployed |
|
||||
| Dependency Moderate security patch/acceptance | Account/Login Next.js/OTel patched in P05-SEC-01; P05-SEC-02 exact seven scoped glob/minimatch override candidates | Run #87: Account 0, Login 2 Moderate; **P05-SEC-02 frozen/build/audit CI pending**, so full clearance NOT YET VERIFIED | Not deployed |
|
||||
| Dependency Moderate security patch/acceptance | P05-SEC-01 direct Next/OTel patches; P05-SEC-02 seven exact glob/minimatch parent overrides | Run #88 Login audit **0 Moderate/High/Critical PASS**; Login frozen install/build/unit **BLOCKED by CI helper false-positive**; post-run fix unverified. Account audit 0 in Run #87 | Not deployed |
|
||||
| Gitea Actions CI and isolated integration tests | Backend-only workflow; interactive identity E2E remains absent | **Run #86 PASS:** disposable backend OIDC ready/discovery/JWKS, Postgres persistence, cleanup; authenticated user E2E pending | No |
|
||||
| Coolify production stack, TLS, routing and backups | No | No | No |
|
||||
| Public `auth.vib.tools/login` URL | Proposed only | No | No |
|
||||
|
||||
+1
-1
@@ -11,7 +11,7 @@ Every file listed below is a direct child of `docs/`. Add/remove rows whenever t
|
||||
| [P05-CI-02.md](P05-CI-02.md) | TypeScript remediation, Gitea CI verification, dependency risk and isolation evidence | P05-CI-02 / run #83 done; Docker acceptance blocked |
|
||||
| [P05-CI-03.md](P05-CI-03.md) | Isolated backend-only Gitea CI procedure, checks and exact run outcomes | P05-CI-03 / Run #86 SUCCESS |
|
||||
| [P05-SEC-01.md](P05-SEC-01.md) | Source-grounded dependency security patches, advisory blockers and CI verification | P05-SEC-01 / Run #87 3 PASS/1 FAIL, 2 Moderate open |
|
||||
| [P05-SEC-02.md](P05-SEC-02.md) | Seven scoped PNPM parent overrides, patched lock and manual Login-only security CI evidence | P05-SEC-02 / run pending |
|
||||
| [P05-SEC-02.md](P05-SEC-02.md) | Seven scoped PNPM parent overrides, patched lock and manual Login-only security CI evidence | P05-SEC-02 / Run #88 partial: security zero, build unverified |
|
||||
| [SETUP-GUIDE.md](SETUP-GUIDE.md) | Operator/developer prerequisites, configs, activation and safety | DOCS-01 / active; runtime pending |
|
||||
| [FEATURES-STATUS.md](FEATURES-STATUS.md) | Exact implemented/unavailable/unverified feature matrix | DOCS-01 / active |
|
||||
| [TROUBLESHOOTING.md](TROUBLESHOOTING.md) | Known blockers and safe diagnosis based on source status | DOCS-01 / active |
|
||||
|
||||
+2
-2
@@ -2,7 +2,7 @@
|
||||
|
||||
**Date:** 2026-11-22
|
||||
**Approved baseline:** `43eee54e7ad6b647e38491ac4dc28703547cf410`
|
||||
**Status:** Targeted source patch prepared; **one Gitea security acceptance run pending**.
|
||||
**Status:** **Run #88 overall FAILURE**: Login live security audit PASS (0 Moderate/High/Critical); frozen install/build/units blocked by CI helper false-positive. Post-run source-only regex correction not CI-verified.
|
||||
|
||||
## Purpose
|
||||
|
||||
@@ -40,4 +40,4 @@ No `users/ui/**` changes, original Login source/route/callback/UI changes, Go ba
|
||||
|
||||
## Real Gitea acceptance ledger
|
||||
|
||||
**PENDING:** one focused run, tested source SHA, actual Login build/unit/security jobs, distinct skipped Account jobs, audit counts and cleanup/evidence. **Do not claim zero advisories before terminal CI evidence.** Detailed pre-edit root-cause proof and implementation log: `notes/P05-SEC-02.md`. Dependency source map: `project/DEPENDENCY-SECURITY.md`.
|
||||
**ACTUAL RUN #88:** [Gitea Actions](https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/88) tested source commit `66cfed5a8b6bd5845b229c9934695e307f9a0775`, `login_only=true`, overall **FAILURE**. Account build (#189) and Account security (#191) intentionally SKIPPED. Login build (#190) FAILED *before* frozen install: new CI validator treated existing `axios@>=...`, `brace-expansion@>=...`, `esbuild@>=...` version ranges as parent selectors due a broad `>` regex. Thus **frozen PNPM install, Next.js standalone build, and upstream unit tests NOT RUN**. Login production security (#192) **PASS**: `pnpm audit --prod` found **zero Moderate/High/Critical**, `PNPM_ADVISORY_RECORDS=0`, `ZITPLANE_PNPM_ZERO_MODERATE_HIGH_CRITICAL_PASS`. The seven parent-scoped glob/minimatch patches eliminated the two previously reported findings from the current registry audit, but their **build/runtime compatibility remains unverified**. After Run #88, narrowed the validator regex to match only `>glob` or `>minimatch` package selectors; **this correction was not tested by CI**. No second run. Full P05-SEC-02 acceptance remains **BLOCKED**; separately approve focused build/unit acceptance using the post-correction SHA. See `notes/P05-SEC-02.md` and `project/DEPENDENCY-SECURITY.md`.
|
||||
+1
-1
@@ -63,7 +63,7 @@ Implement one explicitly approved phase at a time. Keep out-of-scope files, exis
|
||||
- Baseline `43eee54e7ad6b647e38491ac4dc28703547cf410`; prior Gitea Run #87: 3 PASS/1 FAIL, only 2 Login Moderate GHSA (`glob`/`minimatch`) remaining, Account audit 0.
|
||||
- Exact Scope Lock: `auth/ui/v2/pnpm-workspace.yaml`, `pnpm-lock.yaml`, justified root or Login dependency manifests only, `.gitea/workflows/p05-security-acceptance.yml`, focused `tests/ci/**`, notes/project/docs and associated README/MINIFEST. **Login/auth/UI source, users/ui/**, Go backend, developer Compose, other packages and production READ-ONLY.** Preserve untracked AI_INSTRUCTIONS.md.
|
||||
- Seven **exact parent-scoped** overrides: two glob10 parents → glob14.0.6, five minimatch10 parents → minimatch11.0.9. No broad global major override; pinned PNPM 10.30.3 metadata-only lockfile regeneration; compatibility subject to CI proof.
|
||||
- Existing Gitea security workflow `workflow_dispatch.inputs.login_only=true`: skip previously accepted Account jobs; focused Login pinned frozen install, exact resolution contract, Nx production build + upstream Vitest, live fail-closed High/Critical and zero Moderate+ audit. **Exactly one CI cycle**, no local app builds/tests, no production deployment. Final evidence: `notes/P05-SEC-02.md` and `docs/P05-SEC-02.md`.
|
||||
- **Actual Gitea Run #88**, tested source SHA `66cfed5a8b6bd5845b229c9934695e307f9a0775`, overall **FAILURE**: Account jobs correctly SKIPPED, Login live production audit **0 Moderate/High/Critical PASS**; Login build job FAIL before frozen install because new contract helper falsely treated existing `>=` semver ranges as parent overrides. No frozen install/build/units executed in this run. Corrected parser to recognize exact `>glob` or `>minimatch` selectors after the run, **not CI-verified**. Full security/compatibility acceptance **BLOCKED** pending separately approved focused CI; one run only, no local app builds/tests or deployment. Exact evidence: `notes/P05-SEC-02.md`, `docs/P05-SEC-02.md`.
|
||||
|
||||
## P05 - Full Integration (proposed, NOT approved)
|
||||
Shared design system, production-safe Compose topology and verified Login/Account OIDC wiring. No live deployment; separate approval.
|
||||
|
||||
+1
-1
@@ -26,4 +26,4 @@
|
||||
Full update policy is in root [AGENTS.md](../AGENTS.md). A list of available docs is in [MINIFEST.md](MINIFEST.md).
|
||||
|
||||
|
||||
For the seven targeted `glob`/`minimatch` remediation candidates and manual focused Login-only CI instructions see [P05-SEC-02.md](P05-SEC-02.md). For Gitea Run #87 findings see [P05-SEC-01.md](P05-SEC-01.md). For backend-only isolated runtime verification see [P05-CI-03.md](P05-CI-03.md); for initial full workflow and its limitations see [P05-CI-01.md](P05-CI-01.md). A green backend discovery smoke is not an authenticated user-login result.
|
||||
For Run #88 zero-advisory security evidence, blocked Login build gate, post-run unverified CI parser correction and next focused acceptance see [P05-SEC-02.md](P05-SEC-02.md). For Gitea Run #87 findings see [P05-SEC-01.md](P05-SEC-01.md). For backend-only isolated runtime verification see [P05-CI-03.md](P05-CI-03.md); for initial full workflow and its limitations see [P05-CI-01.md](P05-CI-01.md). A green backend discovery smoke is not an authenticated user-login result.
|
||||
@@ -89,3 +89,6 @@ On Gitea `vibtools/ZitPlane` open Actions → `ZitPlane P05-SEC-01 Dependency Se
|
||||
## P05-SEC-02 — focused Login-only dependency security acceptance
|
||||
|
||||
Gitea `vibtools/ZitPlane` → Actions → **ZitPlane P05 Dependency Security Acceptance (SEC-01/02)** → manual Run workflow on `main`, set **`login_only=true`**. This option deliberately skips Account build/security jobs already accepted in Run #87. Only the frozen official Login workspace install, source-level seven-override contract, proto/client/Next standalone build + upstream unit suite and live production pnpm vulnerability gate execute. The expected security threshold is **0 Moderate, 0 High, 0 Critical**. The authenticated OIDC end-to-end flow and production deployment are **not** part of the dependency gate. See `docs/P05-SEC-02.md`.
|
||||
|
||||
|
||||
**P05-SEC-02 verified outcome:** Gitea [Run #88](https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/88) with `login_only=true` proved a clean Login production registry audit (**zero known Moderate/High/Critical**), while Account jobs were correctly skipped. The Login build/unit job did not reach frozen install because a new CI helper misparsed `>=` version-range selectors; a post-run source-only parser correction is **unverified**. **Do not deploy or claim Login dependency compatibility until the separately approved P05-SEC-02-A01 CI completes.** No local build/test is required.
|
||||
@@ -40,3 +40,8 @@ Gitea Run #87 produced 3 PASS and 1 FAIL. The FAILED `security_login` job is a *
|
||||
## P05-SEC-02 — scoped major transitive override troubleshooting
|
||||
|
||||
If a frozen Login install, Nx build or unit suite fails after this patch, verify the seven exact `parent@version>dependency` selectors in `auth/ui/v2/pnpm-workspace.yaml` and the matching `pnpm-lock.yaml` snapshots; compare with `notes/P05-SEC-02.md`. `glob@14` and `minimatch@11` are semver-major transitive substitutions, so historical parents expecting v10 APIs may need a separately approved compatible parent upgrade. **Do not** apply global overrides, blanket `pnpm audit --fix`, disable the strict zero-Moderate gate, or edit protected Login authentication code. Full security acceptance requires current CI frozen install/build/Vitest and registry audit, not just a clean lockfile.
|
||||
|
||||
|
||||
## P05-SEC-02 Run #88: false-positive override validation (not a runtime failure)
|
||||
|
||||
Run #88 Login build job #190 stopped before `pnpm install --frozen-lockfile` when the new `transitive_override_contract.py` classified old `axios@>=...` / `brace-expansion@>=...` / `esbuild@>=...` selectors as extra parent overrides. The regex was narrowed **after** the run to accept only direct `>glob` or `>minimatch` overrides. **This fix has not been tested by CI.** Independent Login production security audit job #192 passed with **0 Moderate, 0 High, 0 Critical**; do not confuse that security result with an authenticated login, a production deployment, or a successful frozen build. A separate, explicitly approved Gitea CI run is required for complete Login dependency compatibility acceptance.
|
||||
+1
-1
@@ -13,6 +13,6 @@ This is the chronological **index**. Phase-specific scope/implementation evidenc
|
||||
| 2026-11-22 | P05-CI-02 | Narrow Auth.js TS2345 fix, CI negative tests, advisory triage and post-run portless override | Run #83: Account/Login/Security PASS, Docker FAIL on host 8080; cleanup PASS; portless override unverified. [Evidence](P05-CI-02.md) |
|
||||
| 2026-11-22 | P05-CI-03 | Backend-only Gitea verification of portless Compose, 4 services, Postgres persistence, OIDC/JWKS and safe cleanup | **Run #86 SUCCESS** on `03fb589`, no unrelated suites rerun; [evidence](P05-CI-03.md) |
|
||||
| 2026-11-22 | P05-SEC-01 | Next.js 16.4.6, compatible OTel instrumentation, frozen locks and strict advisory gates | Run #87: 3 PASS/1 FAIL; 17/19 prior findings no longer reported, 2 Moderate Login blockers. [Evidence](P05-SEC-01.md) |
|
||||
| 2026-11-22 | P05-SEC-02 | Seven exact parent overrides for glob/minimatch, pinned PNPM lock metadata and focused Login-only CI | Source prepared, one CI acceptance run pending. [Plan/evidence](P05-SEC-02.md) |
|
||||
| 2026-11-22 | P05-SEC-02 | Seven scoped parent overrides for glob/minimatch, pinned PNPM lock; one focused Gitea run | Run #88: Login security 0 findings PASS, build gate FAIL before frozen install on CI helper false-positive. Post-run regex fix unverified; [evidence](P05-SEC-02.md) |
|
||||
|
||||
Rules: Append new phases or fixes; never silently rewrite a past result. Separate **implemented**, **verified**, **blocked**, and **proposed**. Never log a user secret or personal data.
|
||||
+1
-1
@@ -9,7 +9,7 @@
|
||||
| [P05-CI-02.md](P05-CI-02.md) | Auth.js narrow patch, isolated Gitea CI gate, advisory triage and exact acceptance evidence | P05-CI-02 / run #83 completed; residual Docker gate blocked |
|
||||
| [P05-CI-03.md](P05-CI-03.md) | Backend-only pre-change scope, disposable CI run evidence and exact acceptance result | P05-CI-03 / Run #86 SUCCESS; acceptance complete |
|
||||
| [P05-SEC-01.md](P05-SEC-01.md) | Pre-change security scope, remediation, exact advisory evidence, one CI run and closure | P05-SEC-01 / Run #87 completed, 2 Moderate open |
|
||||
| [P05-SEC-02.md](P05-SEC-02.md) | Exact root chain, seven PNPM parent overrides, one focused Gitea CI and closure evidence | P05-SEC-02 / source prepared, run pending |
|
||||
| [P05-SEC-02.md](P05-SEC-02.md) | Exact root chain, seven PNPM parent overrides, one focused Gitea CI and closure evidence | P05-SEC-02 / Run #88 security PASS, build blocked; parser post-run patch unverified |
|
||||
| [CHANGELOG.md](CHANGELOG.md) | Short append-only chronological phase log and links to detailed reports | DOCS-01 / active |
|
||||
|
||||
Update this manifest whenever any direct child file or directory changes. Use **actual source state**; a planned file must be labeled planned, not present.
|
||||
+23
-2
@@ -3,7 +3,7 @@
|
||||
**Date:** 2026-11-22
|
||||
**Approved baseline:** `43eee54e7ad6b647e38491ac4dc28703547cf410`
|
||||
**Prior evidence:** Gitea Run [#87](https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/87): 3 PASS / 1 FAIL, Login security 2 Moderate; Account vulnerability audit 0; Login frozen install + production build + 1219/1219 unit tests PASS.
|
||||
**State:** APPROVED / PRE-CHANGE SCOPE LOCK — no P05-SEC-02 source edits yet.
|
||||
**State:** SOURCE PATCH IMPLEMENTED; Run #88 security audit PASS (0 findings), Login build acceptance BLOCKED by CI helper regex false-positive; post-run narrow parser fix **not CI-verified**. Exactly one run.
|
||||
|
||||
## Exact approved Scope Lock
|
||||
|
||||
@@ -31,4 +31,25 @@ No local application builds, installs, tests, dev servers or Docker. **Only a pi
|
||||
|
||||
PASS only when exact vulnerable `glob/minimatch` resolved versions are absent from lock, pinned PNPM **frozen install PASS**, official Login V2 Nx production build and targeted upstream unit regressions PASS, and live Login **pnpm audit --prod** reports **zero Moderate/High/Critical**. A blocking failure is documented, never bypassed. Account security previously zero in Run #87; authenticated OIDC/MFA/production are separate phases.
|
||||
|
||||
**Execution evidence:** PENDING source patch and one Gitea CI run.
|
||||
**Execution evidence:** One Gitea Run #88 completed with 0 Moderate/High/Critical security findings; frozen Login install/build/unit job blocked by helper parsing defect. Detailed terminal evidence appears below.
|
||||
|
||||
|
||||
## Run #88 terminal evidence and targeted follow-up scope — 2026-11-22
|
||||
|
||||
**Gitea Run:** https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/88
|
||||
**Tested Gitea source commit:** `66cfed5a8b6bd5845b229c9934695e307f9a0775`.
|
||||
**Source tree:** `9a1d2abd803f20cd05e428541483c1fa390e14d9`, identical to local source commit `b418442d3a1bf6b6e7e96d4495ea9dc8625d08d3`.
|
||||
**Execution:** one `workflow_dispatch` with `login_only=true`, started 2026-11-22 14:34:04 UTC, terminal 14:34:35 UTC. **Overall FAILURE**, not full acceptance.
|
||||
|
||||
| Job | ID | Terminal result | Proven facts |
|
||||
| --- | ---: | --- | --- |
|
||||
| Account build | 189 | **SKIPPED intentionally** | Account previously passed Run #87; focus limited to Login |
|
||||
| Login frozen/build/unit | 190 | **FAILED before install** | Checkout PASS. New `transitive_override_contract.py` falsely classified existing version-range keys (`axios@>=...`, `brace-expansion@>=...`, `esbuild@>=...`) as parent overrides because its regex merely matched a `>` character. `ZITPLANE_TRANSITIVE_OVERRIDE_CONTRACT_FAIL`; no PNPM frozen install/build/unit tests executed in this run |
|
||||
| Account security | 191 | **SKIPPED intentionally** | Run #87 Account production audit zero |
|
||||
| Login production security | 192 | **PASS** | `pnpm audit --prod` returned **No known vulnerabilities found**; `PNPM_ADVISORY_RECORDS=0`, Moderate=0, High=0, Critical=0, `ZITPLANE_PNPM_ZERO_MODERATE_HIGH_CRITICAL_PASS` |
|
||||
|
||||
**True root cause of CI failure:** the new helper's selector regex must match **an exact trailing `>glob` or `>minimatch` package dependency**, not incidental `>`/ `>=` within existing range keys. The PNPM lockfile itself is not the reason this job failed. A **narrow source-only correction** in `tests/ci/transitive_override_contract.py` is justified; current locked seven parent selectors, dependency versions, application manifests, auth code, and Gitea security gate must remain unchanged.
|
||||
|
||||
**No second CI run in P05-SEC-02.** The post-run regex correction will be recorded as **NOT CI-VERIFIED**. Security advisory clearance is CI-verified (0/0/0); **frozen install, Login build and 1219 unit-regression compatibility for patched transitive majors remain BLOCKED/UNVERIFIED**. Full phase acceptance must wait for a separately approved narrow CI re-verification phase. Any future test must use the latest post-correction source commit, not claim Run #88 tested it.
|
||||
|
||||
**Transport note:** Windows Git HTTPS push returned authentication failure even though prior cached credentials worked. The connected Gitea integration committed all 25 approved source files atomically; **remote/local Git tree IDs were compared and matched exactly**. No credentials printed, replaced or committed. Gitea remote commit SHA differs from local Git commit SHA due the independent authenticated commit transport. Preserve untracked `AI_INSTRUCTIONS.md`.
|
||||
@@ -13,7 +13,7 @@ This is the **developer-focused implementation history**. `notes/CHANGELOG.md` i
|
||||
| 2026-11-22 | P05-CI-02 | Type-safe Auth.js subject narrowing, Account anonymous negative tests, Login regression, structured advisory triage and CI-only portless Docker override | Run #83: 3 PASS/1 FAIL; Docker proxy 8080 collision, cleanup PASS, portless fix unverified; see `notes/P05-CI-02.md` |
|
||||
| 2026-11-22 | P05-CI-03 | Dedicated manual backend-only CI acceptance, guarded disposable Compose, persistence/ready/JWKS probes and owned-state cleanup | **Gitea Run #86 SUCCESS** on `03fb589`; all steps PASS; `notes/P05-CI-03.md` |
|
||||
| 2026-11-22 | P05-SEC-01 | Next.js/OTel minimal security manifests, reproducible locks, dedicated CI and strict Moderate+ gates | Run #87: Account/Login build PASS, Login Vitest 1219/1219, Account audit 0, Login 2 Moderate open; `notes/P05-SEC-01.md` |
|
||||
| 2026-11-22 | P05-SEC-02 | Seven parent-targeted glob/minimatch patched resolutions, PNPM lockfile metadata-only and manual Login-only CI guard | Run pending; `notes/P05-SEC-02.md`, `project/DEPENDENCY-SECURITY.md` |
|
||||
| 2026-11-22 | P05-SEC-02 | Seven parent-targeted glob/minimatch patched resolutions, PNPM lockfile metadata-only, manual Login-only CI and post-run validator fix | Run #88: strict Login audit 0 findings PASS, Login build job blocked before install by parser false-positive; post-run fix untested. `notes/P05-SEC-02.md` |
|
||||
|
||||
## Required entry for each future change
|
||||
|
||||
|
||||
@@ -105,3 +105,8 @@ Existing manual `.gitea/workflows/p05-security-acceptance.yml` now offers `workf
|
||||
`login` starts with CI-only `python3 ../../../tests/ci/transitive_override_contract.py` for the exact seven owned parent overrides and no affected glob/minimatch lock versions, then pinned PNPM frozen install, upstream proto/client/Login standalone build and full `vitest --run` regressions. `security_login` uses existing production PNPM HIGH/CRITICAL audit and independent JSON detail + zero Moderate+ gate; **no suppression**. Both jobs must conclude SUCCESS before declaring P05-SEC-02 accepted. The historical Account zero-vulnerability proof is Gitea Run #87, **not retested** in this focused phase.
|
||||
|
||||
A single manual run is authorized; Git source commit/push precedes dispatch, and final evidence-only documentation commit/push follows without a second run. Source-only audit and actual runner results are distinct; see `notes/P05-SEC-02.md` and `docs/P05-SEC-02.md`.
|
||||
|
||||
|
||||
## Run #88 and CI helper parsing defect — acceptance remains blocked
|
||||
|
||||
Gitea Run #88 source `66cfed5`, exact tree `9a1d2abd`, intentionally skipped Account jobs #189/#191. Login security #192 **PASS** (zero Moderate/High/Critical). Login build #190 **FAIL before frozen install** in `transitive_override_contract.py` due misclassification of existing `>=` version-range keys as parent-scoped overrides. Build/unit steps were **skipped**, not failed application regressions. Narrow post-run regex correction now explicitly accepts only `>glob` / `>minimatch`; **unverified until a newly approved run**. One focused run only; follow-up P05-SEC-02-A01 should run *only* Login frozen/build/unit with security gate, under a separately approved baseline.
|
||||
@@ -66,3 +66,14 @@ Selected exact patch pins `glob@14.0.6` and `minimatch@11.0.9` are **published**
|
||||
The seven *semver-major transitive* substitutions require runtime compatibility proofs. `tests/ci/transitive_override_contract.py` checks exact selector ownership, absence of vulnerable lock versions, unchanged importer requirements and the seven parent→version resolutions; it is CI-only. Manual Gitea security workflow option `login_only=true` skips previously accepted Account jobs, executes Login frozen install/build/upstream unit suite and a **strict zero Moderate/High/Critical** live production registry audit. Leave original Login auth, Account Portal, backend, deployment and unrelated package manifests read-only. Source presence is not a production-security guarantee.
|
||||
|
||||
**Security acceptance:** PENDING the one focused Gitea run. If registry audit or upstream regression fails, document exact blocker rather than suppressing findings or silently changing major versions.
|
||||
|
||||
|
||||
## P05-SEC-02 Gitea Run #88 outcome (2026-11-22)
|
||||
|
||||
**Actual tested remote source:** `66cfed5a8b6bd5845b229c9934695e307f9a0775`, remote tree `9a1d2abd803f20cd05e428541483c1fa390e14d9` matched the local 25-file approved source commit tree byte-for-byte. One manual `login_only=true` Gitea Run [#88](https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/88), overall **FAILURE**, two Account jobs skipped as intended.
|
||||
|
||||
**Login production security job #192 PASS:** real registry `pnpm audit --prod` reported `No known vulnerabilities found`, exactly `moderate=0, high=0, critical=0` and `ZITPLANE_PNPM_ZERO_MODERATE_HIGH_CRITICAL_PASS`. Both `glob` and `minimatch` prior Moderate findings no longer reproduce in this lock-based production audit. Previous Account registry audit was 0 in Run #87 (not rerun).
|
||||
|
||||
**Login frozen/build/unit job #190 FAIL before install:** newly written `tests/ci/transitive_override_contract.py` treated historical `axios@>=1.0.0`, `brace-expansion@>=4.0.0`, and `esbuild@>=0.27.3` version-range selectors as new parent overrides because the regex matched any `>`. That is a **validator false-positive**; it does **not** establish pinned PNPM frozen install or Nx/Next/1219-unit compatibility with the semver-major overrides. The helper regex was then narrowed to match **only terminal `>glob` / `>minimatch` selectors**. This final narrow correction has **NOT been executed in CI**, and there was no second run.
|
||||
|
||||
**Verdict:** advisory clearance **VERIFIED** in Run #88; full dependency compatibility/phase acceptance **BLOCKED** pending **P05-SEC-02-A01** isolated Login frozen install, production build, upstream unit suite, exact contract and retained zero-advisory gate. No authentication/UI/backend/Account source change or production deployment. Do not assert that historical Run #87's successful builds validate the newly overridden glob/minimatch majors.
|
||||
@@ -116,3 +116,6 @@ Workflow shell commands are written directly under `.gitea/workflows/p05-securit
|
||||
`tests/ci/transitive_override_contract.py::main()` reads the existing `auth/ui/v2/pnpm-workspace.yaml` and resolved `pnpm-lock.yaml` (no network or side effects), verifies exactly seven parent-specific override selectors, checks the four required PNPM importers, rejects any known affected glob (>=9 <=14.0.1) or minimatch (>=7 <11.0.1) snapshot, and asserts that all seven parent dependencies resolve to the exact patched version. Failure returns nonzero in CI; it does not hide audit failures or alter dependencies.
|
||||
|
||||
Existing `tests/ci/security_advisory_gate.py` remains the independent **live registry report** gate, rejecting malformed reports and any Moderate/High/Critical finding. A clean lockfile alone cannot prove that the live advisory audit passes.
|
||||
|
||||
|
||||
**P05-SEC-02 post-run correction:** `overridden(data)` in `tests/ci/transitive_override_contract.py` originally matched every `>`, incorrectly interpreting `axios@>=...`, `brace-expansion@>=...` and `esbuild@>=...` existing PNPM version constraints as new parent-child override selectors. The matching expression now restricts the suffix to `>glob` or `>minimatch` only, preserving the seven exact patch-parent check without changing registry audit logic. Run #88 predates the fix; this parser has **not yet passed CI**. Auth/session flows untouched.
|
||||
@@ -73,3 +73,6 @@ Run #86 on commit `03fb589` executed a backend-only manual Gitea Actions job and
|
||||
Pre-change source and registry metadata identified two direct `glob@10.5.0` parents and five direct `minimatch@10.2.5/10.2.6` parents. The seven *parent-specific* root workspace overrides point to published `glob@14.0.6` and `minimatch@11.0.9` (Node 22 supported). Pinned PNPM `10.30.3 install --lockfile-only --ignore-scripts --no-frozen-lockfile` generated only lock metadata without app installation/build/tests. `glob@14` now depends on patched `minimatch@11`; `minimatch@3/5` are unaffected by the reported GHSA version ranges.
|
||||
|
||||
These are **major** dependency migrations underneath older parents, not an upstream source edit. Only a green Gitea Login Nx production build and upstream unit tests, frozen PNPM install and registry audit can certify compatibility and advisory clearance. The existing security workflow has a manual `login_only=true` focused mode; previously accepted Account results remain from Run #87.
|
||||
|
||||
|
||||
**P05-SEC-02 actual acceptance boundary:** Run #88 `pnpm audit --prod` found **0 known Moderate/High/Critical advisories** for the 7 scoped patched parent resolutions. But new CI helper matching `>=` as parent override stopped Login frozen install before any app build/unit case ran. Post-run regex fix to recognize only `>glob` and `>minimatch` is **not CI-verified**. The dependency migration is not yet production-accepted. Do not run local app builds/tests or silently replace the pinned PNPM lock; use separately approved Login-only Gitea acceptance.
|
||||
@@ -1,6 +1,6 @@
|
||||
# Git-tracked source inventory ? exact paths
|
||||
|
||||
**Snapshot:** 2026-11-22, P05-SEC-02 source preparation from approved baseline `43eee54`. **The focused Gitea SEC-02 CI has not yet run.**
|
||||
**Snapshot:** 2026-11-22, P05-SEC-02 Git-tracked source inventory. Gitea Run #88 tested remote commit `66cfed5`, found zero Login Moderate/High/Critical advisories but build job stopped on new CI helper false-positive. Post-run parser fix is **not CI-verified**; final docs/source SHA differs from tested Run #88 SHA.
|
||||
|
||||
**Git-tracked paths: 732.** Untracked `AI_INSTRUCTIONS.md` and ignored secrets excluded.
|
||||
|
||||
|
||||
+1
-1
@@ -16,6 +16,6 @@ No real credentials or production domains are used. Never print bootstrap PATs,
|
||||
|
||||
- `security_advisory_gate.py` (P05-SEC-01) takes npm or pnpm registry audit JSON, rejects missing/errored/inconsistent metadata and requires **zero Moderate/High/Critical findings**. It is independent of the existing HIGH+ audit command and `advisory_triage.py` detailed advisory ID report. **Gitea Run #87** proved Account audit 0 and Login audit **2 Moderate** (`glob`, `minimatch`); strict Login gate correctly FAILED. Dedicated `.gitea/workflows/p05-security-acceptance.yml` is manual only; frozen installs/builds are CI-only and passed 1219/1219 Login unit regressions.
|
||||
|
||||
- `transitive_override_contract.py` (P05-SEC-02) validates exactly seven parent-scoped PNPM override selectors, absence of known advisory-affected glob/minimatch lock entries, preserved importer structure and each exact patched parent resolution. This is **source-only** and not a live security audit; still require strict Gitea registry `security_advisory_gate.py`, frozen pnpm install, Nx production build and unit suite. Trigger the existing Gitea security workflow with manual `login_only=true`; Account build/security jobs should be skipped.
|
||||
- `transitive_override_contract.py` (P05-SEC-02) validates seven exact parent-scoped PNPM overrides, lock/importer consistency and absence of affected glob/minimatch versions. **Run #88 failed in this helper before pnpm frozen install** because its first regex also matched existing `>=` version-range override keys. Post-run regex restricted to `>glob`/`>minimatch` parent selectors, **not CI-tested**; next separately approved focused run required. The independent Run #88 live production advisory audit found 0 Moderate/High/Critical. Account jobs skipped as expected with `login_only=true`.
|
||||
|
||||
Add new CI checks and update `MINIFEST.md`, `project/`, `docs/`, and `notes/` in the same approved phase.
|
||||
@@ -27,7 +27,7 @@ EXPECTED = {
|
||||
def overridden(data: str) -> dict[str, str]:
|
||||
found: dict[str, str] = {}
|
||||
for line in data.splitlines():
|
||||
match = re.match(r"^ ['\"]?([^'\"#][^:]*>[^:'\"]+)['\"]?: ['\"]?([^'\" #]+)", line)
|
||||
match = re.match(r"^ ['\"]?([^'\"#:]+>(?:glob|minimatch))['\"]?: ['\"]?([^'\" #]+)", line)
|
||||
if match:
|
||||
found[match.group(1)] = match.group(2).rstrip("'\":")
|
||||
return found
|
||||
|
||||
Reference in new issue
Block a user