Files
ZitPlane/notes/P05-SEC-02-A01.md
T

4.1 KiB

P05-SEC-02-A01 — Login Build and Security Final Acceptance

Date: 2026-11-22 Approved Gitea main baseline: 7655dbdcb48c49aab8f3bf97aab8f1867f129531 Previous tested SHA: 66cfed5a8b6bd5845b229c9934695e307f9a0775, Gitea Run #88 Pre-change status: APPROVED, SCOPE LOCKED, Gitea acceptance PENDING. This report was written before any P05-SEC-02-A01 source edit.

Approved exact scope

  • Potential source writes only on newly reproduced targeted defects: tests/ci/transitive_override_contract.py, .gitea/workflows/p05-security-acceptance.yml.
  • Routine writes: notes/**, project/**, relevant docs/**, associated README/MINIFEST and root navigation only when required.
  • STRICT read-only: auth/ui/v2/pnpm-workspace.yaml, auth/ui/v2/pnpm-lock.yaml, all package manifests, Login V2 application/auth/UI source, users/ui/**, core/backend/zitadel/**, deployment/docker/**, all production configuration, secrets and unrelated files. Preserve untracked AI_INSTRUCTIONS.md.
  • No local app installs/builds/tests/dev servers or Docker; no real accounts/secrets, deployment, tags or releases. Exactly ONE focused Gitea Actions acceptance run; do not rerun or rewrite source opportunistically.

Root-cause proof and pre-implementation plan

  1. Gitea Run #88 verified Login pnpm audit --prod: 0 Moderate, 0 High, 0 Critical (security job #192 PASS). Both Account jobs intentionally SKIPPED via login_only=true; Login build job #190 failed before frozen install because the first P05-SEC-02 contract regex matched existing axios@>=..., brace-expansion@>=..., esbuild@>=... version-range overrides as parent selectors. Thus no Login frozen install, Nx production build or upstream Vitest executed in that run. The failed run cannot prove dependency API compatibility.
  2. In post-run source commit 7655dbd..., tests/ci/transitive_override_contract.py::overridden() now matches only keys with an explicit trailing >glob or >minimatch (regex [^\\"#:]+>(?:glob|minimatch)), not incidental >= in version ranges. Review source only, including both workspace and locked header override definitions, exact seven expected parent selectors, preserved imported Login/client/proto importers and absence of vulnerable package snapshots. Do not execute the helper locally: the user specifically deferred tests to Gitea CI.
  3. Gitea manual workflow .gitea/workflows/p05-security-acceptance.yml already supports workflow_dispatch.inputs.login_only=true: Account build and Account security jobs are conditioned to SKIP; only login and security_login jobs run. Login job: corrected source contract → pnpm@10.30.3 install --frozen-lockfile → original proto/client/Login production standalone build → upstream Vitest. Security job: live pnpm audit --prod, fail-closed High/Critical and strict zero Moderate/High/Critical gate.
  4. No new application/CI code edit planned unless a fresh read-only review finds an exact defect. Commit this pre-run scope/evidence plan and synchronize Gitea main, then dispatch exactly ONE focused CI run at the committed SHA. Confirm no unapproved changes and that the two Account jobs are skipped. If either Login job fails, document exact terminal blocker rather than loop/rerun or claim PASS.
  5. Document terminal job IDs, tested SHA, frozen install/Nx build/standalone/Vitest count, strict advisory severities and result; sync notes/project/docs and manifests, one closure commit, Gitea push and exact remote+local SHA verification. The final docs-only commit is NOT the tested CI SHA.

Acceptance gates

FULL PASS only if on the same tested SHA: exact seven-scoped override contract PASS; pnpm install --frozen-lockfile PASS; official Login Nx proto/client and standalone Next build PASS; upstream Login unit suite PASS with actual counts; Login live registry audit 0 Moderate/High/Critical; Account jobs SKIPPED intentionally; CI run overall SUCCESS and no unrelated source changes. Without these, phase remains BLOCKED.

CI evidence ledger: PENDING the one authorized Gitea Actions run.