docs: record P05 security run 87 and two moderate blockers

This commit is contained in:
Vib Tools committed 2026-11-22 06:16:57 -08:00
1 parent 752d243ae8
commit 43eee54e7a
18 files changed
+77 -16

No files matched your search

+1 -1
View File
@@ -12,7 +12,7 @@ This is the **developer-focused implementation history**. `notes/CHANGELOG.md` i
| 2026-11-22 | P05-CI-01 | `.gitea/workflows/p05-ci.yml`, `tests/ci/**`, Account npm lock, Login pnpm importer reconciliation and in-scope Alpine Git checkout correction | Run #81 overall FAIL; 2 jobs PASS, 2 FAIL; Login 1219/1219 tests PASS, Account TS2345 and Docker checkout blocked; `notes/P05-CI-01.md` |
| 2026-11-22 | P05-CI-02 | Type-safe Auth.js subject narrowing, Account anonymous negative tests, Login regression, structured advisory triage and CI-only portless Docker override | Run #83: 3 PASS/1 FAIL; Docker proxy 8080 collision, cleanup PASS, portless fix unverified; see `notes/P05-CI-02.md` |
| 2026-11-22 | P05-CI-03 | Dedicated manual backend-only CI acceptance, guarded disposable Compose, persistence/ready/JWKS probes and owned-state cleanup | **Gitea Run #86 SUCCESS** on `03fb589`; all steps PASS; `notes/P05-CI-03.md` |
| 2026-11-22 | P05-SEC-01 | Next.js/OTel minimal security manifest and metadata-only locks; strict Moderate+ audits and build/regression CI; no app/UI source modifications | Source under review, one Gitea CI cycle pending; `notes/P05-SEC-01.md` |
| 2026-11-22 | P05-SEC-01 | Next.js/OTel minimal security manifests, reproducible locks, dedicated CI and strict Moderate+ gates | Run #87: Account/Login build PASS, Login Vitest 1219/1219, Account audit 0, Login 2 Moderate open; `notes/P05-SEC-01.md` |
## Required entry for each future change
+5
View File
@@ -91,3 +91,8 @@ Manual Gitea-only `.gitea/workflows/p05-security-acceptance.yml` has four indepe
Each registry job first runs `npm audit --omit=dev --audit-level=high` or `pnpm audit --prod --audit-level high` under `set -eu` to fail-closed on High/Critical. Then nonmutating JSON is collected, `tests/ci/advisory_triage.py` prints exact IDs/package/range/fix, and `tests/ci/security_advisory_gate.py` requires complete/count-consistent JSON and **zero Moderate/High/Critical**. Any Moderate is an actual failed gate, not a warning disguised as acceptance.
Only approved manifest and lockfile metadata were patched; original Login/auth/API/UI source, `pnpm-workspace.yaml`, P02 backend, Compose, real credentials and production unchanged. Two transitive glob/minimatch risks may remain because the root PNPM override configuration is outside Scope Lock and those require semver-major upgrades. See `project/DEPENDENCY-SECURITY.md` for the original 18+1 records and exact immediate parents; source state is not proof of advisory resolution until actual Gitea run.
## P05-SEC-01 Run #87 terminal job results
Manual [Run #87](https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/87) tested `752d243`. Account job #185 PASS; Login job #186 PASS (frozen pnpm, Nx Next 16.4.6 build and 1219 unit cases); Account security job #187 PASS at all levels with 0 findings; Login security job #188 FAIL on **two Moderate** `glob`/`minimatch` advisories (0 High/Critical). The strict `tests/ci/security_advisory_gate.py` did not suppress them, so **overall run FAILURE** is expected and correct. Full source/security acceptance remains blocked pending a separate narrow transitive dependency phase; no repeated run or application source change.
+15 -1
View File
@@ -38,4 +38,18 @@ This table identifies **immediate parents present in the archived PNPM lock grap
Expected patched direct candidates: Next.js `16.4.6` both apps; Login `@opentelemetry/auto-instrumentations-node@0.80.0`, `@opentelemetry/sdk-node@0.222.0`, `@opentelemetry/api-logs@0.222.0`. **OPEN candidate blockers:** glob >=14.0.2, minimatch >=11.0.1 require separately approved scoped parent/override changes.
**CI PENDING:** live audit may expose new or unchanged vulnerabilities; never declare zero Moderate from manifest text alone. The follow-up result record will list all remaining exact IDs, job statuses and a separate narrow remediation plan.
**CI VERIFIED in Run #87:** the live registry audit did report two unchanged Moderate transitive vulnerabilities (`glob`, `minimatch`). See the terminal outcome section below. No claim of full security acceptance.
## Gitea Run #87 verified outcome — 2026-11-22
**Tested SHA:** `752d243ae8fb24ce3cfa990343082e2d0431306b`.
**Run:** https://dev.ivib.cc/vibtools/ZitPlane/actions/runs/87, **overall FAILURE** (3 job PASS/1 security job FAIL), manual only.
- **Account:** pinned npm v3 lock frozen install, Next.js 16.4.6/TypeScript production build and anonymous negative identity regressions PASS. Production npm audit **0 vulnerabilities** (0 Moderate/High/Critical), job #187 PASS.
- **Login:** pinned pnpm v10.30.3 **frozen install** (1131 packages), Nx proto/client/Next.js 16.4.6 standalone build PASS; upstream Vitest **84/84 test files, 1219/1219 unit tests PASS**. Its production pnpm audit had **zero High/Critical**, but **2 Moderate**; job #188 intentionally FAIL due fail-closed zero-Moderate gate.
- **Still open:** `GHSA-3g3m-2fjr-6pw4` (`glob`, upgrade >=14.0.2) and `GHSA-g3hv-75wg-m249` (`minimatch`, upgrade >=11.0.1). Immediate parent version constraints remain incompatible with blind semver-major upgrades. The authoritative PNPM workspace override file is read-only in P05-SEC-01.
- **No longer reported:** 7 old Next.js Login records, 9 old OpenTelemetry Login records, 1 old Account `next` vulnerable package record — 17/19 original records disappeared from current registry audit. This is not proof of runtime exploitability or of zero future advisories.
- Remaining P05-SEC-02 focus: narrow authorized `auth/ui/v2/pnpm-workspace.yaml` overrides or compatible parent dependency upgrades, reproducible pinned lock, exact transitive resolution and fail-closed Gitea frozen/security/build/unit acceptance. No login/auth/UI source changes.
**P05-SEC-01 classification: PATCH IMPLEMENTED AND BUILDS PASS; SECURITY ACCEPTANCE BLOCKED, not a production release.** Final docs-only SHA differs from the tested Run #87 source SHA.
+3
View File
@@ -63,3 +63,6 @@ Run #86 on commit `03fb589` executed a backend-only manual Gitea Actions job and
- The imported PNPM lock previously retained snapshots from an upstream monorepo larger than the 4-member ZitPlane workspace. Regeneration pruned many no-longer-reachable snapshots, with only metadata file changes inside approved scope; root workspace `pnpm-workspace.yaml` and imported code unchanged. The Gitea **frozen install** is the required proof of consistency.
- Advisory resolution cannot be claimed merely from versions. `glob@10.5.0` and `minimatch@10.2.x` remain in the lockfile through tooling parents with older major ranges, and the workspace override file is read-only. Their Moderate advisories stay OPEN until proven fixed or separately approved.
- Dedicated manual Gitea `p05-security-acceptance.yml` performs Account/Login frozen builds and a strict High/Critical + Moderate gate. Prior P05 backend Run #86 was successful and was **not** deployed.
**P05-SEC-01 Gitea verification result:** Run #87 on `752d243` proved both frozen installs and production builds, and the Login upstream unit suite **1219/1219 PASS**. Account production audit returned 0 vulnerabilities. Login production audit returned **2 Moderate transitive issues** (glob 14.x and minimatch 11.x patch lines require compatible override/parent work) and zero High/Critical. The strict Moderate gate **failed as intended**. Do not interpret the patched manifest/lockfile as full vulnerability clearance; P05-SEC-02 needs a newly approved change to the read-only PNPM workspace overrides.
+1 -1
View File
@@ -1,6 +1,6 @@
# Source inventory ? all Git-tracked paths
**Snapshot:** 2026-11-22, P05-SEC-01 security source on approved baseline `1a60255`; the new security CI run has not yet been executed.
**Snapshot:** 2026-11-22, P05-SEC-01 source and docs on approved baseline `1a60255`; Gitea Run #87 tested source commit `752d243` (3 PASS / 1 FAIL, 2 Moderate transitive advisories still open). Later documentation-only commit not a new CI test.
**Exact Git-tracked paths: 729.** Original upstream source semantics unchanged; untracked `AI_INSTRUCTIONS.md` and ignored local secrets excluded.