From fac0934a00e6c15902738a3ffafb11b5ec2f0ac3 Mon Sep 17 00:00:00 2001 From: Md Nurnobi Date: Sun, 22 Nov 2026 12:24:38 +0000 Subject: [PATCH] ci(p03): close CI verification and document advisory release block [skip ci] --- .gitea/workflows/datastack-ci.yml | 123 ++++++++++++++++++----- .gitea/workflows/datastack-docker-ci.yml | 36 +++---- notes/001-PRODUCTION-FORENSIC-AUDIT.md | 8 ++ notes/002-PRODUCTION-UPDATE-ROADMAP.md | 8 ++ notes/003-PHASE-STATUS-LOG.md | 17 ++++ notes/004-ERROR-HANDLING-REGISTER.md | 9 ++ notes/005-ACTUAL-FEATURE-REGISTER.md | 8 ++ notes/006-BASELINE-AND-PATCH-EVIDENCE.md | 12 +++ 8 files changed, 178 insertions(+), 43 deletions(-) diff --git a/.gitea/workflows/datastack-ci.yml b/.gitea/workflows/datastack-ci.yml index 818fe9e..73302d9 100644 --- a/.gitea/workflows/datastack-ci.yml +++ b/.gitea/workflows/datastack-ci.yml @@ -16,10 +16,15 @@ on: required: false type: boolean default: false + python_only: + description: Narrow CI-06 Python job rerun after a proven runner setup failure + required: false + type: boolean + default: false jobs: node-regression: - if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.quality_only != 'true' }} + if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.quality_only != 'true' && (github.event_name != 'workflow_dispatch' || github.event.inputs.python_only != 'true') }} runs-on: ubuntu-latest timeout-minutes: 30 steps: @@ -52,25 +57,36 @@ jobs: python-regression: if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.p01_only != 'true' }} runs-on: ubuntu-latest - timeout-minutes: 15 + container: node:22-bookworm-slim + timeout-minutes: 20 steps: - - uses: actions/checkout@v4 - with: - github-server-url: https://dev.ivib.cc - - name: Install Python toolchain + - name: Install Bookworm Python and checkout prerequisites run: | set -eu apt-get update -qq - apt-get install -y python3 python3-venv python3-pip - python3 -m venv /tmp/datastack-ci-venv - /tmp/datastack-ci-venv/bin/python -m pip install -e ./sdk/python/datastack -e ./sdk-python - - name: Run all Python SDK tests + apt-get install -y --no-install-recommends git ca-certificates python3 python3-venv python3-pip + - uses: actions/checkout@v4 + with: + github-server-url: https://dev.ivib.cc + - name: CI-06 Python 3.11 isolated virtual environment run: | set -eu - /tmp/datastack-ci-venv/bin/python -m compileall -q ./sdk/python/datastack ./sdk-python - /tmp/datastack-ci-venv/bin/python -m unittest discover -s tests -p '*_test.py' -v + python3 --version + python3 -m venv /tmp/datastack-ci-venv + /tmp/datastack-ci-venv/bin/python -m pip install --disable-pip-version-check -e ./sdk/python/datastack -e ./sdk-python + - name: CI-06 compile and assert 14 Python SDK regressions + run: | + set -eu + py=/tmp/datastack-ci-venv/bin/python + "$py" -m compileall -q ./sdk/python/datastack ./sdk-python + "$py" -m unittest discover -s tests -p '*_test.py' -v > /tmp/datastack-python-tests.log 2>&1 || { cat /tmp/datastack-python-tests.log; exit 1; } + cat /tmp/datastack-python-tests.log + grep -Eq '^Ran 14 tests in ' /tmp/datastack-python-tests.log + grep -Eq '^OK$' /tmp/datastack-python-tests.log + echo DATASTACK_PYTHON_14_OF_14_PASS quality: + if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.python_only != 'true' }} runs-on: ubuntu-latest timeout-minutes: 20 steps: @@ -85,7 +101,7 @@ jobs: run: npm run lint production-build: - if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.quality_only != 'true' }} + if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.quality_only != 'true' && (github.event_name != 'workflow_dispatch' || github.event.inputs.python_only != 'true') }} runs-on: ubuntu-latest timeout-minutes: 25 steps: @@ -101,30 +117,45 @@ jobs: test -f .next/standalone/server.js docker-image-build: - if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.p01_only != 'true' }} + if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.p01_only != 'true' && (github.event_name != 'workflow_dispatch' || github.event.inputs.python_only != 'true') }} runs-on: ubuntu-latest - timeout-minutes: 35 + container: node:22-alpine + timeout-minutes: 45 steps: + - name: CI-07 provision Docker Buildx CLI + run: | + set -eu + apk add --no-cache git docker-cli docker-cli-buildx docker-cli-compose + docker --version + docker buildx version + docker compose version - uses: actions/checkout@v4 with: github-server-url: https://dev.ivib.cc - - name: Docker and Compose availability + - name: CI-07 inspect daemon and validate Compose without starting services run: | set -eu - docker --version - docker compose version - docker info - - name: Validate Compose structure - run: docker compose -f docker/docker-compose.yml config --no-interpolate --quiet - - name: Build Docker images without running services + docker info --format 'Driver={{.Driver}} Root={{.DockerRootDir}}' + df -h . + docker compose -f docker/docker-compose.yml config --no-interpolate --quiet + echo DATASTACK_COMPOSE_CONFIG_PASS + - name: CI-07 isolated BuildKit all three images (no deployment) run: | set -eu - docker build -f docker/Dockerfile.server -t datastack-ci-ingestion . - docker build -f docker/Dockerfile.web -t datastack-ci-web . - docker build -f docker/Dockerfile.proxy -t datastack-ci-proxy . + builder="datastack-p03-${GITHUB_RUN_ID:-0}-${GITHUB_RUN_ATTEMPT:-1}" + tag="datastack-p03-${GITHUB_SHA:-local}" + cleanup() { docker buildx rm --force "$builder" >/dev/null 2>&1 || true; } + trap cleanup EXIT + docker buildx create --name "$builder" --driver docker-container --use + docker buildx inspect "$builder" --bootstrap + docker buildx build --builder "$builder" --progress=plain --no-cache --load -f docker/Dockerfile.server -t "$tag-ingestion" . + docker buildx build --builder "$builder" --progress=plain --no-cache --load -f docker/Dockerfile.web -t "$tag-web" . + docker buildx build --builder "$builder" --progress=plain --no-cache --load -f docker/Dockerfile.proxy -t "$tag-proxy" . + docker image inspect "$tag-ingestion" "$tag-web" "$tag-proxy" >/dev/null + echo DATASTACK_THREE_IMAGES_BUILD_PASS windows-compatibility: - if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.quality_only != 'true' }} + if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.quality_only != 'true' && (github.event_name != 'workflow_dispatch' || github.event.inputs.python_only != 'true') }} runs-on: windows-latest timeout-minutes: 25 steps: @@ -150,3 +181,43 @@ jobs: if ($LASTEXITCODE -ne 0) { throw 'SDK install failed' } npm --prefix sdk/node/datastack run build if ($LASTEXITCODE -ne 0) { throw 'SDK compilation failed' } + + security-audit: + if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.p01_only != 'true' && (github.event_name != 'workflow_dispatch' || github.event.inputs.python_only != 'true') }} + runs-on: ubuntu-latest + container: node:22-alpine + timeout-minutes: 15 + steps: + - name: Install checkout prerequisite + run: apk add --no-cache git + - uses: actions/checkout@v4 + with: + github-server-url: https://dev.ivib.cc + - name: CI-08 read-only full and runtime npm advisory inventory + run: | + set -eu + if npm audit --json > /tmp/datastack-audit-full.json; then :; else test "$?" -eq 1; fi + if npm audit --omit=dev --json > /tmp/datastack-audit-runtime.json; then :; else test "$?" -eq 1; fi + node <<'NODE' + const fs = require("node:fs"); + for (const scope of ["full", "runtime"]) { + const audit = JSON.parse(fs.readFileSync("/tmp/datastack-audit-" + scope + ".json", "utf8")); + if (!audit.metadata || !audit.metadata.vulnerabilities || !audit.vulnerabilities) { + throw Error("Incomplete npm audit response for " + scope); + } + console.log("AUDIT_COUNTS " + scope + " " + JSON.stringify(audit.metadata.vulnerabilities)); + for (const [name, item] of Object.entries(audit.vulnerabilities)) { + const advisories = (item.via || []).filter(v => typeof v === "object").map(v => ({ + id: v.source, url: v.url, range: v.range, severity: v.severity + })); + console.log("AUDIT_PACKAGE " + scope + " " + JSON.stringify({ + package: name, severity: item.severity, direct: item.isDirect, + range: item.range, via: advisories, + viaPackages: (item.via || []).filter(v => typeof v === "string"), + fixAvailable: item.fixAvailable + })); + } + } + NODE + git diff --exit-code -- package.json package-lock.json + echo DATASTACK_SECURITY_TRIAGE_INVENTORY_PASS diff --git a/.gitea/workflows/datastack-docker-ci.yml b/.gitea/workflows/datastack-docker-ci.yml index 039defb..9669498 100644 --- a/.gitea/workflows/datastack-docker-ci.yml +++ b/.gitea/workflows/datastack-docker-ci.yml @@ -1,39 +1,41 @@ name: DataStack Docker Build CI on: - push: - branches: [main] - paths: - - '.gitea/workflows/datastack-docker-ci.yml' workflow_dispatch: jobs: docker-build: runs-on: ubuntu-latest container: node:22-alpine - timeout-minutes: 40 + timeout-minutes: 45 steps: - - name: Provision isolated Docker CLI and Git tools + - name: CI-07 provision Docker Buildx CLI run: | set -eu - apk add --no-cache git docker-cli docker-cli-compose + apk add --no-cache git docker-cli docker-cli-buildx docker-cli-compose docker --version + docker buildx version docker compose version - uses: actions/checkout@v4 with: github-server-url: https://dev.ivib.cc - - name: Validate actual Compose configuration + - name: CI-07 inspect daemon and validate Compose without starting services run: | set -eu + docker info --format 'Driver={{.Driver}} Root={{.DockerRootDir}}' + df -h . docker compose -f docker/docker-compose.yml config --no-interpolate --quiet echo DATASTACK_COMPOSE_CONFIG_PASS - - name: Check CI-only Docker daemon + - name: CI-07 isolated BuildKit all three images (no deployment) run: | set -eu - docker info >/dev/null || { echo DOCKER_DAEMON_UNAVAILABLE; exit 3; } - - name: Build all DataStack container images without deployment - run: | - set -eu - docker build -f docker/Dockerfile.server -t datastack-ci-ingestion . - docker build -f docker/Dockerfile.web -t datastack-ci-web . - docker build -f docker/Dockerfile.proxy -t datastack-ci-proxy . - echo DATASTACK_DOCKER_IMAGES_PASS + builder="datastack-p03-${GITHUB_RUN_ID:-0}-${GITHUB_RUN_ATTEMPT:-1}" + tag="datastack-p03-${GITHUB_SHA:-local}" + cleanup() { docker buildx rm --force "$builder" >/dev/null 2>&1 || true; } + trap cleanup EXIT + docker buildx create --name "$builder" --driver docker-container --use + docker buildx inspect "$builder" --bootstrap + docker buildx build --builder "$builder" --progress=plain --no-cache --load -f docker/Dockerfile.server -t "$tag-ingestion" . + docker buildx build --builder "$builder" --progress=plain --no-cache --load -f docker/Dockerfile.web -t "$tag-web" . + docker buildx build --builder "$builder" --progress=plain --no-cache --load -f docker/Dockerfile.proxy -t "$tag-proxy" . + docker image inspect "$tag-ingestion" "$tag-web" "$tag-proxy" >/dev/null + echo DATASTACK_THREE_IMAGES_BUILD_PASS diff --git a/notes/001-PRODUCTION-FORENSIC-AUDIT.md b/notes/001-PRODUCTION-FORENSIC-AUDIT.md index 3922676..770fafa 100644 --- a/notes/001-PRODUCTION-FORENSIC-AUDIT.md +++ b/notes/001-PRODUCTION-FORENSIC-AUDIT.md @@ -121,3 +121,11 @@ Gitea [CI #69](https://dev.ivib.cc/vibtools/DataStack/actions/runs/69) was run a ### P02 definitive CI acceptance (2026-11-22) Source-verified P02 final correction is `acca8be01a31f8d3972564cbaec8fd3117a0b551`. [Gitea CI #72](https://dev.ivib.cc/vibtools/DataStack/actions/runs/72) terminal **SUCCESS** (Linux 24/24 TypeScript suites, explicit R-01/R-02 fault cases, strict tsc, ESLint, Windows Node SDK, Next.js standalone build). Earlier #69 was cancelled after a test-only global `Date.now` Socket.IO ACK timeout; fixed by removing global clock override and adding direct arithmetic proof without changing timers. #72 proves the corrected test passes. Final source-path audit: exactly 11 approved paths (3 runtime, 2 tests, 6 notes). No keys/secrets, auth/SDK/UI/public health, dependency pins, CI workflows, deployment or database migrations changed. ACK remains **best-effort in intentionally Redis-free RAM mode**; Redis-configured RPUSH failure must return negative ACK; CSV deduplication guarantees only tested recovery windows, not globally atomic exactly-once. Partition scans are memory-streamed but disk reads scale with matching partition size, and production throughput is NOT certified. Release/installation still requires separate authorization. + +## P03 production forensic acceptance — 2026-11-22 + +Baseline Gitea/GitHub `48fb277079b380fdbf1e58cd2da40afeed0b03ee`; GitLab baseline same tracked tree `41a169eec0c05ce19bc4acc29d7a8cfe1f8dd90d` (317/317 blobs). Final P03 workflow candidate `549d575653b68c29f97e2f78036646f2e2035719`. [Gitea CI #77](https://dev.ivib.cc/vibtools/DataStack/actions/runs/77): overall **FAILURE** because the initial Python-only checkout lacked Node (exit 127), **not** an SDK regression. Its other six jobs terminal **SUCCESS**: Node `CI_SUITE_SUMMARY total=24 failed=0`, strict TS+ESLint, Next standalone build, Windows SDK, Compose + isolated BuildKit ingestion/web/proxy image build `DATASTACK_THREE_IMAGES_BUILD_PASS`, read-only advisory inventory `DATASTACK_SECURITY_TRIAGE_INVENTORY_PASS`. Narrow [Python-only CI #78](https://dev.ivib.cc/vibtools/DataStack/actions/runs/78) terminal **SUCCESS**: Node-capable Bookworm container, Python 3.11 isolated venv, `Ran 14 tests in 3.959s`, `OK`, `DATASTACK_PYTHON_14_OF_14_PASS`. The other six jobs were deliberately skipped in #78. + +**CI-08 security disposition:** `npm audit --json` full=26 affected packages (25 moderate, 1 high); runtime=24 (23 moderate, 1 high), **not counts of distinct advisories**. High-severity advisories [GHSA-6g55-p6wh-862q](https://github.com/advisories/GHSA-6g55-p6wh-862q), [GHSA-r28c-9q8g-f849](https://github.com/advisories/GHSA-r28c-9q8g-f849) affect Next 15.5.29's nested `postcss@8.4.31` despite patched root `postcss@8.5.33`; npm recommends major `next@16.4.6`. Direct `cloudcmd@19.24.0` carries moderate transitive issues (`dompurify`, `file-type`, `glob`, `minimatch`, `got`); npm recommends `cloudcmd@17.0.2` downgrade, not a verified safe pin. No speculative package pin, major upgrade or force fix; a separately tested compatible remediation is needed before release. + +**Scope / release decision:** only `.gitea/workflows/datastack-ci.yml`, `.gitea/workflows/datastack-docker-ci.yml`, and `notes/001–006` changed. No `package.json`/lock, Dockerfile, application UI/UX, runtime, auth, SDK, database, Compose, production data, secret, shared Docker prune, deployment, migration, tag or release. P03 technical CI and advisory-triage acceptance verified by #77 non-Python jobs plus #78 Python; do **not** mislabel #77 overall as successful. Final phase publication requires one main commit and Gitea/GitHub/GitLab exact tracked tree parity. **Production release NO-GO** while runtime high advisory is unresolved; live production health, throughput and deployment remain unverified. diff --git a/notes/002-PRODUCTION-UPDATE-ROADMAP.md b/notes/002-PRODUCTION-UPDATE-ROADMAP.md index 74e9149..1b19c60 100644 --- a/notes/002-PRODUCTION-UPDATE-ROADMAP.md +++ b/notes/002-PRODUCTION-UPDATE-ROADMAP.md @@ -125,3 +125,11 @@ Use one focused Gitea CI, strict patch/security diff, notes/001–006 update, Gi No live deployment, migrations, tags or releases. Close P03 only on verified acceptance; provide production release readiness report. ``` + +## P03 scoped execution and release gate — 2026-11-22 + +Baseline Gitea/GitHub `48fb277079b380fdbf1e58cd2da40afeed0b03ee`; GitLab baseline same tracked tree `41a169eec0c05ce19bc4acc29d7a8cfe1f8dd90d` (317/317 blobs). Final P03 workflow candidate `549d575653b68c29f97e2f78036646f2e2035719`. [Gitea CI #77](https://dev.ivib.cc/vibtools/DataStack/actions/runs/77): overall **FAILURE** because the initial Python-only checkout lacked Node (exit 127), **not** an SDK regression. Its other six jobs terminal **SUCCESS**: Node `CI_SUITE_SUMMARY total=24 failed=0`, strict TS+ESLint, Next standalone build, Windows SDK, Compose + isolated BuildKit ingestion/web/proxy image build `DATASTACK_THREE_IMAGES_BUILD_PASS`, read-only advisory inventory `DATASTACK_SECURITY_TRIAGE_INVENTORY_PASS`. Narrow [Python-only CI #78](https://dev.ivib.cc/vibtools/DataStack/actions/runs/78) terminal **SUCCESS**: Node-capable Bookworm container, Python 3.11 isolated venv, `Ran 14 tests in 3.959s`, `OK`, `DATASTACK_PYTHON_14_OF_14_PASS`. The other six jobs were deliberately skipped in #78. + +**CI-08 security disposition:** `npm audit --json` full=26 affected packages (25 moderate, 1 high); runtime=24 (23 moderate, 1 high), **not counts of distinct advisories**. High-severity advisories [GHSA-6g55-p6wh-862q](https://github.com/advisories/GHSA-6g55-p6wh-862q), [GHSA-r28c-9q8g-f849](https://github.com/advisories/GHSA-r28c-9q8g-f849) affect Next 15.5.29's nested `postcss@8.4.31` despite patched root `postcss@8.5.33`; npm recommends major `next@16.4.6`. Direct `cloudcmd@19.24.0` carries moderate transitive issues (`dompurify`, `file-type`, `glob`, `minimatch`, `got`); npm recommends `cloudcmd@17.0.2` downgrade, not a verified safe pin. No speculative package pin, major upgrade or force fix; a separately tested compatible remediation is needed before release. + +**Scope / release decision:** only `.gitea/workflows/datastack-ci.yml`, `.gitea/workflows/datastack-docker-ci.yml`, and `notes/001–006` changed. No `package.json`/lock, Dockerfile, application UI/UX, runtime, auth, SDK, database, Compose, production data, secret, shared Docker prune, deployment, migration, tag or release. P03 technical CI and advisory-triage acceptance verified by #77 non-Python jobs plus #78 Python; do **not** mislabel #77 overall as successful. Final phase publication requires one main commit and Gitea/GitHub/GitLab exact tracked tree parity. **Production release NO-GO** while runtime high advisory is unresolved; live production health, throughput and deployment remain unverified. diff --git a/notes/003-PHASE-STATUS-LOG.md b/notes/003-PHASE-STATUS-LOG.md index 271254c..c7d3717 100644 --- a/notes/003-PHASE-STATUS-LOG.md +++ b/notes/003-PHASE-STATUS-LOG.md @@ -135,3 +135,20 @@ The authorized Windows PC attempted a **local disposable** `npm.cmd ci --ignore- - **Historical testing:** #66 PASS candidate; #69 suite failure (Socket.IO ACK timeout caused by test-only global `Date.now` override) and cancellation; #72 PASS corrected source/test. No false claim that #69 succeeded. - Final code/diff safety audit: 11/11 approved paths only: `server/index.js`, `server/socket/handlers.js`, `core/data/buffer.ts`, `tests/phase02-sync.test.ts`, `tests/phase03-storage-buffer.test.ts`, plus `notes/001–006`; `git diff --check` and JS syntax PASS. Original PC root old staged P01 (16 paths) and separate dirty earlier temporary worktree preserved. - **Publication gate:** Gitea PR #3 final verified source + documentation notes; squash-merge with `[skip ci]`, publish to GitHub and GitLab, verify identical tracked Git trees despite potentially different GitLab commit SHA. P02 marked CLOSED only after three-remote content parity; evidence SHA/tree in operator's final publication report. P03 NOT STARTED and requires separate approval. + +## P03 final CI acceptance ledger — 2026-11-22 + +| Gate | Terminal outcome | +| --- | --- | +| #77 Node | SUCCESS, 24/24 | +| #77 TypeScript / ESLint | SUCCESS | +| #77 Next standalone build | SUCCESS | +| #77 Windows Node SDK | SUCCESS | +| #77 isolated three-image BuildKit | SUCCESS | +| #77 read-only npm audit inventory | SUCCESS with 1 high runtime finding | +| #77 Python | FAILED before tests: checkout requires Node | +| #78 corrected Python-only | SUCCESS, 14/14; other jobs SKIPPED | + +**CI-08 security disposition:** `npm audit --json` full=26 affected packages (25 moderate, 1 high); runtime=24 (23 moderate, 1 high), **not counts of distinct advisories**. High-severity advisories [GHSA-6g55-p6wh-862q](https://github.com/advisories/GHSA-6g55-p6wh-862q), [GHSA-r28c-9q8g-f849](https://github.com/advisories/GHSA-r28c-9q8g-f849) affect Next 15.5.29's nested `postcss@8.4.31` despite patched root `postcss@8.5.33`; npm recommends major `next@16.4.6`. Direct `cloudcmd@19.24.0` carries moderate transitive issues (`dompurify`, `file-type`, `glob`, `minimatch`, `got`); npm recommends `cloudcmd@17.0.2` downgrade, not a verified safe pin. No speculative package pin, major upgrade or force fix; a separately tested compatible remediation is needed before release. + +**Scope / release decision:** only `.gitea/workflows/datastack-ci.yml`, `.gitea/workflows/datastack-docker-ci.yml`, and `notes/001–006` changed. No `package.json`/lock, Dockerfile, application UI/UX, runtime, auth, SDK, database, Compose, production data, secret, shared Docker prune, deployment, migration, tag or release. P03 technical CI and advisory-triage acceptance verified by #77 non-Python jobs plus #78 Python; do **not** mislabel #77 overall as successful. Final phase publication requires one main commit and Gitea/GitHub/GitLab exact tracked tree parity. **Production release NO-GO** while runtime high advisory is unresolved; live production health, throughput and deployment remain unverified. diff --git a/notes/004-ERROR-HANDLING-REGISTER.md b/notes/004-ERROR-HANDLING-REGISTER.md index 118884a..7828bcd 100644 --- a/notes/004-ERROR-HANDLING-REGISTER.md +++ b/notes/004-ERROR-HANDLING-REGISTER.md @@ -102,3 +102,12 @@ If a `batch_sync` contains only (a) an uncommitted Redis-claim duplicate and (b) ### P02 terminal CI #72 error handling acceptance Gitea #72 **SUCCESS** at verified final code SHA `acca8be01a31f8d3972564cbaec8fd3117a0b551`; all 24 TS suites exit zero including stale claim, mixed batch (both with new durable event and old durable duplicate), Redis-free compatibility, gzip/rotated CSV and corrupt matching CSV fail-closed. `BUFFER_PERSIST_FAILED` is negative-ACK response on configured Redis write failure, rather than success for RAM fallback. Redis-free RAM mode old semantics unchanged. Existing 401/403/429/503/507 tests unaffected and pass within 24 suites. Public /health liveness remains HTTP 200 with `redisConnected:false` during mocked outage; separate readiness endpoint not approved. Remaining risk: no atomic Redis+CSV commit, no global exactly-once guarantee, CSV partition scan disk I/O grows with volume. No live traffic test. + +## P03 runner/security defect register — 2026-11-22 + +- **CI-06:** `python:3.12-slim-bookworm` lacked Node for `actions/checkout@v4` (127). Approved workflow-only correction: `node:22-bookworm-slim` plus Debian Python 3.11 venv and prerequisites; narrow CI #78 **14/14 PASS**. +- **CI-07:** Historical classic Docker `COPY node_modules/@uiw` layer-export failure was not reproduced using disposable BuildKit builder; #77 Compose and 3/3 builds plus image inspect **PASS**; no Dockerfile modifications or shared prune. +- **CI-08:** **CI-08 security disposition:** `npm audit --json` full=26 affected packages (25 moderate, 1 high); runtime=24 (23 moderate, 1 high), **not counts of distinct advisories**. High-severity advisories [GHSA-6g55-p6wh-862q](https://github.com/advisories/GHSA-6g55-p6wh-862q), [GHSA-r28c-9q8g-f849](https://github.com/advisories/GHSA-r28c-9q8g-f849) affect Next 15.5.29's nested `postcss@8.4.31` despite patched root `postcss@8.5.33`; npm recommends major `next@16.4.6`. Direct `cloudcmd@19.24.0` carries moderate transitive issues (`dompurify`, `file-type`, `glob`, `minimatch`, `got`); npm recommends `cloudcmd@17.0.2` downgrade, not a verified safe pin. No speculative package pin, major upgrade or force fix; a separately tested compatible remediation is needed before release. +- **Runtime API errors:** P02's 401/403/429/503/507, `BUFFER_PERSIST_FAILED` negative ACK, Redis/CSV replay behavior and public `/health` shape unchanged; no live production fault claims. + +**Scope / release decision:** only `.gitea/workflows/datastack-ci.yml`, `.gitea/workflows/datastack-docker-ci.yml`, and `notes/001–006` changed. No `package.json`/lock, Dockerfile, application UI/UX, runtime, auth, SDK, database, Compose, production data, secret, shared Docker prune, deployment, migration, tag or release. P03 technical CI and advisory-triage acceptance verified by #77 non-Python jobs plus #78 Python; do **not** mislabel #77 overall as successful. Final phase publication requires one main commit and Gitea/GitHub/GitLab exact tracked tree parity. **Production release NO-GO** while runtime high advisory is unresolved; live production health, throughput and deployment remain unverified. diff --git a/notes/005-ACTUAL-FEATURE-REGISTER.md b/notes/005-ACTUAL-FEATURE-REGISTER.md index 0fb2a1e..ae6ea06 100644 --- a/notes/005-ACTUAL-FEATURE-REGISTER.md +++ b/notes/005-ACTUAL-FEATURE-REGISTER.md @@ -78,3 +78,11 @@ Gitea #69 node-regression observed one **fixture timeout**, not a proven new pro - **P02 R-02: FIXED for verified crash/replay windows**, not global transactionality. Port4000 and Port3000 CSV replay suppresses duplicate same-client/day/eventId across plain, rotated and gz; failed reads prevent trimming; dedicated regression tests PASS. Streaming parser bounded memory, disk read throughput/latency not yet load-tested. - **P02 R-03: UNCHANGED**: public /health remains backwards-compatible liveness, not a dependency-readiness endpoint. Production live health **NOT VERIFIED**. - All other runtime features/UI/auth/API/SDK/database/Compose and package dependencies unchanged. **P02 CI ACCEPTED at #72**; code SHA `acca8be01a31f8d3972564cbaec8fd3117a0b551`. Phase closed only after verified 3-way content sync. No P03 implementation or production deployment. + +## P03 feature invariance — 2026-11-22 + +P03 modifies workflow verification and Markdown evidence only, not a product feature. No UI, API, auth, SDK, DB, CSV, Redis, Dockerfile, Compose or deployment change. The P02 regression contract remains 24/24 PASS; corrected Python SDK passes 14/14; all three Docker images build without running them. Read-only npm advisory triage is complete but **not security-clean**. + +**CI-08 security disposition:** `npm audit --json` full=26 affected packages (25 moderate, 1 high); runtime=24 (23 moderate, 1 high), **not counts of distinct advisories**. High-severity advisories [GHSA-6g55-p6wh-862q](https://github.com/advisories/GHSA-6g55-p6wh-862q), [GHSA-r28c-9q8g-f849](https://github.com/advisories/GHSA-r28c-9q8g-f849) affect Next 15.5.29's nested `postcss@8.4.31` despite patched root `postcss@8.5.33`; npm recommends major `next@16.4.6`. Direct `cloudcmd@19.24.0` carries moderate transitive issues (`dompurify`, `file-type`, `glob`, `minimatch`, `got`); npm recommends `cloudcmd@17.0.2` downgrade, not a verified safe pin. No speculative package pin, major upgrade or force fix; a separately tested compatible remediation is needed before release. + +**Scope / release decision:** only `.gitea/workflows/datastack-ci.yml`, `.gitea/workflows/datastack-docker-ci.yml`, and `notes/001–006` changed. No `package.json`/lock, Dockerfile, application UI/UX, runtime, auth, SDK, database, Compose, production data, secret, shared Docker prune, deployment, migration, tag or release. P03 technical CI and advisory-triage acceptance verified by #77 non-Python jobs plus #78 Python; do **not** mislabel #77 overall as successful. Final phase publication requires one main commit and Gitea/GitHub/GitLab exact tracked tree parity. **Production release NO-GO** while runtime high advisory is unresolved; live production health, throughput and deployment remain unverified. diff --git a/notes/006-BASELINE-AND-PATCH-EVIDENCE.md b/notes/006-BASELINE-AND-PATCH-EVIDENCE.md index fbda522..f605f58 100644 --- a/notes/006-BASELINE-AND-PATCH-EVIDENCE.md +++ b/notes/006-BASELINE-AND-PATCH-EVIDENCE.md @@ -287,3 +287,15 @@ Base: Gitea/GitHub published P02 diagnostic tree `fd57a3518d14bcb8367ce9ab9c3ec3 - Historical #69 failed one test-only global Date.now-induced Socket.IO timeout, **not** a demonstrated runtime regression; corrected #72 PASS. No secret or credential introduction, no production data access. - Final audit `git diff --check` PASS and source JS syntax checks PASS; exact tracked source diff from diagnosis = 11 allowlisted files (3 runtime + 2 test + 6 notes); no unrelated UI/auth/SDK/public health, DB schema, package metadata, Docker, CI workflow or live deployment. - Git release gate: final docs-only commits after tested source SHA add **no source/test differences**. Gitea PR #3 squashed into one `[skip ci]` main commit; GitHub/GitLab tracked Git trees must match Gitea before final CLOSED. If GitLab commit SHA differs because of parent history, compare tree SHA not commit SHA. Store exact remote SHAs/trees in phase close operator report; do not invent them before push. + +## H. P03 exact audit and terminal evidence — 2026-11-22 + +Baseline Gitea/GitHub `48fb277079b380fdbf1e58cd2da40afeed0b03ee`; GitLab baseline same tracked tree `41a169eec0c05ce19bc4acc29d7a8cfe1f8dd90d` (317/317 blobs). Final P03 workflow candidate `549d575653b68c29f97e2f78036646f2e2035719`. [Gitea CI #77](https://dev.ivib.cc/vibtools/DataStack/actions/runs/77): overall **FAILURE** because the initial Python-only checkout lacked Node (exit 127), **not** an SDK regression. Its other six jobs terminal **SUCCESS**: Node `CI_SUITE_SUMMARY total=24 failed=0`, strict TS+ESLint, Next standalone build, Windows SDK, Compose + isolated BuildKit ingestion/web/proxy image build `DATASTACK_THREE_IMAGES_BUILD_PASS`, read-only advisory inventory `DATASTACK_SECURITY_TRIAGE_INVENTORY_PASS`. Narrow [Python-only CI #78](https://dev.ivib.cc/vibtools/DataStack/actions/runs/78) terminal **SUCCESS**: Node-capable Bookworm container, Python 3.11 isolated venv, `Ran 14 tests in 3.959s`, `OK`, `DATASTACK_PYTHON_14_OF_14_PASS`. The other six jobs were deliberately skipped in #78. + +**Docker evidence:** separate BuildKit `docker-container` builder with owned-builder cleanup, `--no-cache --load`, actual Compose `config --no-interpolate --quiet`, ingestion/web/proxy Dockerfiles *read-only*, three tags inspected; old `@uiw` error absent. **Python evidence:** only Node-capable image change within workflow, Python 3.11 venv with all 14 tests; Python SDK source unchanged. + +**CI-08 security disposition:** `npm audit --json` full=26 affected packages (25 moderate, 1 high); runtime=24 (23 moderate, 1 high), **not counts of distinct advisories**. High-severity advisories [GHSA-6g55-p6wh-862q](https://github.com/advisories/GHSA-6g55-p6wh-862q), [GHSA-r28c-9q8g-f849](https://github.com/advisories/GHSA-r28c-9q8g-f849) affect Next 15.5.29's nested `postcss@8.4.31` despite patched root `postcss@8.5.33`; npm recommends major `next@16.4.6`. Direct `cloudcmd@19.24.0` carries moderate transitive issues (`dompurify`, `file-type`, `glob`, `minimatch`, `got`); npm recommends `cloudcmd@17.0.2` downgrade, not a verified safe pin. No speculative package pin, major upgrade or force fix; a separately tested compatible remediation is needed before release. + +**Exact allowlist audit:** pre-documentation candidate diff had only two approved workflow files; final publication includes six approved `notes/001–006` updates. Workflow checks: no trailing whitespace, no `docker ... prune`, no `npm audit fix --force`, all 3 Dockerfile paths present, no runtime or dependency lock changes. Check three-remote tracked tree parity before marking phase CLOSED. + +**Scope / release decision:** only `.gitea/workflows/datastack-ci.yml`, `.gitea/workflows/datastack-docker-ci.yml`, and `notes/001–006` changed. No `package.json`/lock, Dockerfile, application UI/UX, runtime, auth, SDK, database, Compose, production data, secret, shared Docker prune, deployment, migration, tag or release. P03 technical CI and advisory-triage acceptance verified by #77 non-Python jobs plus #78 Python; do **not** mislabel #77 overall as successful. Final phase publication requires one main commit and Gitea/GitHub/GitLab exact tracked tree parity. **Production release NO-GO** while runtime high advisory is unresolved; live production health, throughput and deployment remain unverified.