feat: protect admin mutations from cross-origin requests

This commit is contained in:
i vib committed 2026-10-25 15:26:14 -07:00
1 parent 31b310d1b9
commit df14ee1a9a
1 file changed
+36
+36
View File
@@ -2,6 +2,7 @@ import { verifyAdminSessionToken } from "@/core/auth/adminSession";
import { NextRequest, NextResponse } from "next/server"; import { NextRequest, NextResponse } from "next/server";
const SESSION_COOKIE = "datastack_admin_session"; const SESSION_COOKIE = "datastack_admin_session";
const SAFE_METHODS = new Set(["GET", "HEAD", "OPTIONS"]);
function isProtectedApi(pathname: string, method: string) { function isProtectedApi(pathname: string, method: string) {
if (pathname === "/api/auth/login") return false; if (pathname === "/api/auth/login") return false;
@@ -11,6 +12,30 @@ function isProtectedApi(pathname: string, method: string) {
return pathname.startsWith("/api/"); return pathname.startsWith("/api/");
} }
function isSameOriginRequest(request: NextRequest) {
const originHeader = request.headers.get("origin");
const requestHost = request.headers.get("host");
if (!originHeader || !requestHost) return false;
try {
const origin = new URL(originHeader);
const forwardedProtocol = request.headers
.get("x-forwarded-proto")
?.split(",")[0]
.trim()
.toLowerCase();
const requestProtocol =
forwardedProtocol || request.nextUrl.protocol.replace(/:$/, "");
return (
origin.host.toLowerCase() === requestHost.toLowerCase() &&
origin.protocol === `${requestProtocol}:`
);
} catch {
return false;
}
}
export async function middleware(request: NextRequest) { export async function middleware(request: NextRequest) {
const { pathname } = request.nextUrl; const { pathname } = request.nextUrl;
const isLoginPage = pathname === "/vcon/login"; const isLoginPage = pathname === "/vcon/login";
@@ -20,10 +45,21 @@ export async function middleware(request: NextRequest) {
!isLoginPage && !isLoginPage &&
!isSetupPage; !isSetupPage;
const isAdminApi = isProtectedApi(pathname, request.method); const isAdminApi = isProtectedApi(pathname, request.method);
const isStateChangingApi =
pathname.startsWith("/api/") &&
!SAFE_METHODS.has(request.method) &&
pathname !== "/api/events";
if (isSetupPage) return NextResponse.next(); if (isSetupPage) return NextResponse.next();
if (!isConsolePage && !isAdminApi && !isLoginPage) return NextResponse.next(); if (!isConsolePage && !isAdminApi && !isLoginPage) return NextResponse.next();
if (isStateChangingApi && !isSameOriginRequest(request)) {
return NextResponse.json(
{ error: "Cross-origin request rejected." },
{ status: 403 },
);
}
const sessionSecret = process.env.DATASTACK_ADMIN_SESSION_SECRET; const sessionSecret = process.env.DATASTACK_ADMIN_SESSION_SECRET;
const token = request.cookies.get(SESSION_COOKIE)?.value; const token = request.cookies.get(SESSION_COOKIE)?.value;
const authenticated = Boolean( const authenticated = Boolean(