refactor: standardize session cookie configuration

Centralize cookie security options to dynamically detect HTTPS, ensure secure transport, and update client-side auth handlers to use explicit credential inclusion for cookie-based sessions.
This commit is contained in:
Team Dark Devil committed 2026-11-16 22:12:48 +06:00
1 parent fde2c86b1e
commit b42029f67d
8 files changed
+80 -53

No files matched your search

+9 -15
View File
@@ -1,22 +1,18 @@
import { createAdminSessionToken } from "@/core/auth/adminSession";
import {
createAdminSessionToken,
getSessionCookieOptions,
} from "@/core/auth/adminSession";
import {
clearAdminLoginAttempts,
consumeAdminLoginAttempt,
verifyAdminCredentials,
} from "@/core/auth/adminUsers";
import { NextRequest, NextResponse } from "next/server";
import { createHash, timingSafeEqual } from "node:crypto";
const SESSION_COOKIE = "datastack_admin_session";
const SESSION_SECONDS = 8 * 60 * 60;
const REMEMBERED_SESSION_SECONDS = 30 * 24 * 60 * 60;
function constantTimeEqual(left: string, right: string) {
const leftHash = createHash("sha256").update(left).digest();
const rightHash = createHash("sha256").update(right).digest();
return timingSafeEqual(leftHash, rightHash);
}
export async function POST(request: NextRequest) {
const sessionSecret =
process.env.DATASTACK_ADMIN_SESSION_SECRET ||
@@ -100,13 +96,11 @@ export async function POST(request: NextRequest) {
);
const response = NextResponse.json({ success: true });
response.cookies.set(SESSION_COOKIE, token, {
httpOnly: true,
secure: process.env.NODE_ENV === "production",
sameSite: "strict",
path: "/",
maxAge,
});
response.cookies.set(
SESSION_COOKIE,
token,
getSessionCookieOptions(request, maxAge),
);
return response;
} catch {
+4 -7
View File
@@ -1,15 +1,12 @@
import { NextResponse } from "next/server";
import { getSessionCookieOptions } from "@/core/auth/adminSession";
import { NextRequest, NextResponse } from "next/server";
const SESSION_COOKIE = "datastack_admin_session";
export async function POST() {
export async function POST(request: NextRequest) {
const response = NextResponse.json({ success: true });
response.cookies.set(SESSION_COOKIE, "", {
httpOnly: true,
secure: process.env.NODE_ENV === "production",
sameSite: "strict",
path: "/",
maxAge: 0,
...getSessionCookieOptions(request, 0),
expires: new Date(0),
});
return response;
+9 -8
View File
@@ -1,4 +1,7 @@
import { createAdminSessionToken } from "@/core/auth/adminSession";
import {
createAdminSessionToken,
getSessionCookieOptions,
} from "@/core/auth/adminSession";
import {
createInitialAdmin,
isAdminSetupComplete,
@@ -90,13 +93,11 @@ export async function POST(request: NextRequest) {
Date.now() + SESSION_SECONDS * 1000,
);
const response = NextResponse.json({ success: true });
response.cookies.set(SESSION_COOKIE, token, {
httpOnly: true,
secure: process.env.NODE_ENV === "production",
sameSite: "strict",
path: "/",
maxAge: SESSION_SECONDS,
});
response.cookies.set(
SESSION_COOKIE,
token,
getSessionCookieOptions(request, SESSION_SECONDS),
);
return response;
} catch {
return NextResponse.json(