feat(auth): implement RBAC audit logging and session security

Integrate granular audit logging for admin actions, transition to role-based API access via `requireAdminApiSession`, and update session tokens to persist user roles and IDs for consistent multi-admin management.
This commit is contained in:
Team Dark Devil committed 2026-11-20 18:48:54 +06:00
1 parent 2873b9904a
commit 5c977d6977
37 files changed
+5939 -349

No files matched your search

+88 -36
View File
@@ -1,12 +1,12 @@
import { verifyRequestAdminSession } from "@/core/auth/adminUsers";
import { recordAdminAuditLogAsync } from "@/core/auth/auditLog";
import { SDKManager } from "@/core/sdk/sdkManager";
import {
validateAllowedIpsInput,
validateClientExpiresAtInput,
} from "@/core/Security/ipAllowlist";
import { extractClientIp, requireAdminApiSession } from "@/lib/adminAuth";
import { NextRequest, NextResponse } from "next/server";
const SESSION_COOKIE = "datastack_admin_session";
const ALLOWED_PATCH_KEYS = new Set([
"action",
"name",
@@ -21,14 +21,12 @@ export async function GET(
req: NextRequest,
{ params }: { params: Promise<{ id: string }> },
) {
const auth = await verifyRequestAdminSession(
req.cookies.get(SESSION_COOKIE)?.value,
);
const includeToken = req.nextUrl.searchParams.get("includeToken") === "true";
const auth = await requireAdminApiSession(req, {
minRole: includeToken ? "operator" : "viewer",
});
if (!auth.valid) {
return NextResponse.json(
{ error: "Authentication required." },
{ status: auth.reason === "UNAUTHORIZED" ? 401 : 503 },
);
return auth.response;
}
const { id } = await params;
@@ -40,7 +38,6 @@ export async function GET(
}
const { secret, token, ...clientSummary } = client;
void secret;
const includeToken = req.nextUrl.searchParams.get("includeToken") === "true";
return NextResponse.json({
client: {
...clientSummary,
@@ -65,14 +62,9 @@ export async function PATCH(
req: NextRequest,
{ params }: { params: Promise<{ id: string }> },
) {
const auth = await verifyRequestAdminSession(
req.cookies.get(SESSION_COOKIE)?.value,
);
const auth = await requireAdminApiSession(req, { minRole: "operator" });
if (!auth.valid) {
return NextResponse.json(
{ error: "Authentication required." },
{ status: auth.reason === "UNAUTHORIZED" ? 401 : 503 },
);
return auth.response;
}
const { id } = await params;
@@ -90,7 +82,10 @@ export async function PATCH(
if (!rawBody || typeof rawBody !== "object" || Array.isArray(rawBody)) {
return NextResponse.json(
{ error: "Update payload must be a JSON object.", code: "VALIDATION_ERROR" },
{
error: "Update payload must be a JSON object.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -120,8 +115,23 @@ export async function PATCH(
try {
const refreshed = await SDKManager.regenerateTokenAsync(normalizedId);
if (!refreshed) {
return NextResponse.json({ error: "Client not found" }, { status: 404 });
return NextResponse.json(
{ error: "Client not found" },
{ status: 404 },
);
}
await recordAdminAuditLogAsync({
actorEmail: auth.auth.session.email,
actorRole: auth.auth.session.role || "owner",
action: "CLIENT_TOKEN_ROTATED",
target: refreshed.clientId,
ipAddress: extractClientIp(req),
metadata: {
clientId: refreshed.clientId,
},
});
return NextResponse.json({ client: refreshed });
} catch (err: unknown) {
const message =
@@ -130,7 +140,9 @@ export async function PATCH(
return NextResponse.json(
{
error: message,
code: isDbWrite ? "DATABASE_WRITE_FAILED" : "TOKEN_REGENERATION_FAILED",
code: isDbWrite
? "DATABASE_WRITE_FAILED"
: "TOKEN_REGENERATION_FAILED",
},
{ status: isDbWrite ? 503 : 500 },
);
@@ -152,7 +164,10 @@ export async function PATCH(
body.name.trim().length > 120
) {
return NextResponse.json(
{ error: "Client name must be a non-empty string (max 120 characters).", code: "VALIDATION_ERROR" },
{
error: "Client name must be a non-empty string (max 120 characters).",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -166,7 +181,10 @@ export async function PATCH(
body.rateLimit > 100000
) {
return NextResponse.json(
{ error: "rateLimit must be an integer between 1 and 100000.", code: "VALIDATION_ERROR" },
{
error: "rateLimit must be an integer between 1 and 100000.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -180,7 +198,10 @@ export async function PATCH(
body.storageQuotaMb > 1048576
) {
return NextResponse.json(
{ error: "storageQuotaMb must be an integer between 0 and 1048576.", code: "VALIDATION_ERROR" },
{
error: "storageQuotaMb must be an integer between 0 and 1048576.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -196,7 +217,10 @@ export async function PATCH(
const ipValidation = validateAllowedIpsInput(body.allowedIps);
if (!ipValidation.valid) {
return NextResponse.json(
{ error: ipValidation.error || "Invalid allowedIps.", code: "VALIDATION_ERROR" },
{
error: ipValidation.error || "Invalid allowedIps.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -206,16 +230,22 @@ export async function PATCH(
const expValidation = validateClientExpiresAtInput(body.expiresAt);
if (!expValidation.valid) {
return NextResponse.json(
{ error: expValidation.error || "Invalid expiresAt.", code: "VALIDATION_ERROR" },
{
error: expValidation.error || "Invalid expiresAt.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
updates.expiresAt = expValidation.normalized;
updates.expiresAt = expValidation.iso ?? null;
}
if (body.status !== undefined) {
if (body.status !== "active" && body.status !== "revoked") {
return NextResponse.json(
{ error: "status must be 'active' or 'revoked'.", code: "VALIDATION_ERROR" },
{
error: "status must be 'active' or 'revoked'.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -224,7 +254,10 @@ export async function PATCH(
if (Object.keys(updates).length === 0) {
return NextResponse.json(
{ error: "No valid fields provided for update.", code: "VALIDATION_ERROR" },
{
error: "No valid fields provided for update.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -234,6 +267,16 @@ export async function PATCH(
if (!updated) {
return NextResponse.json({ error: "Client not found" }, { status: 404 });
}
await recordAdminAuditLogAsync({
actorEmail: auth.auth.session.email,
actorRole: auth.auth.session.role || "owner",
action: "CLIENT_UPDATED",
target: updated.clientId,
ipAddress: extractClientIp(req),
metadata: updates,
});
return NextResponse.json({ client: updated });
} catch (err: unknown) {
const message = err instanceof Error ? err.message : "Update failed";
@@ -252,14 +295,9 @@ export async function DELETE(
req: NextRequest,
{ params }: { params: Promise<{ id: string }> },
) {
const auth = await verifyRequestAdminSession(
req.cookies.get(SESSION_COOKIE)?.value,
);
const auth = await requireAdminApiSession(req, { minRole: "operator" });
if (!auth.valid) {
return NextResponse.json(
{ error: "Authentication required." },
{ status: auth.reason === "UNAUTHORIZED" ? 401 : 503 },
);
return auth.response;
}
const { id } = await params;
@@ -272,13 +310,27 @@ export async function DELETE(
if (!result.deleted) {
return NextResponse.json({ error: "Client not found" }, { status: 404 });
}
await recordAdminAuditLogAsync({
actorEmail: auth.auth.session.email,
actorRole: auth.auth.session.role || "owner",
action: "CLIENT_DELETED",
target: normalizedId,
ipAddress: extractClientIp(req),
metadata: {
purgeFiles,
purgedFiles: result.purgedFiles,
},
});
return NextResponse.json({
success: true,
message: `Client ${normalizedId} deleted`,
purgedFiles: result.purgedFiles,
});
} catch (err: unknown) {
const message = err instanceof Error ? err.message : "Client deletion failed";
const message =
err instanceof Error ? err.message : "Client deletion failed";
const isDbWrite = message.includes("DATABASE_WRITE_FAILED");
return NextResponse.json(
{
+60 -27
View File
@@ -1,22 +1,16 @@
import { verifyRequestAdminSession } from "@/core/auth/adminUsers";
import { recordAdminAuditLogAsync } from "@/core/auth/auditLog";
import { SDKManager } from "@/core/sdk/sdkManager";
import {
validateAllowedIpsInput,
validateClientExpiresAtInput,
} from "@/core/Security/ipAllowlist";
import { extractClientIp, requireAdminApiSession } from "@/lib/adminAuth";
import { NextRequest, NextResponse } from "next/server";
const SESSION_COOKIE = "datastack_admin_session";
export async function GET(req: NextRequest) {
const auth = await verifyRequestAdminSession(
req.cookies.get(SESSION_COOKIE)?.value,
);
const auth = await requireAdminApiSession(req, { minRole: "viewer" });
if (!auth.valid) {
return NextResponse.json(
{ error: "Authentication required." },
{ status: auth.reason === "UNAUTHORIZED" ? 401 : 503 },
);
return auth.response;
}
try {
@@ -37,14 +31,9 @@ export async function GET(req: NextRequest) {
}
export async function POST(req: NextRequest) {
const auth = await verifyRequestAdminSession(
req.cookies.get(SESSION_COOKIE)?.value,
);
const auth = await requireAdminApiSession(req, { minRole: "operator" });
if (!auth.valid) {
return NextResponse.json(
{ error: "Authentication required." },
{ status: auth.reason === "UNAUTHORIZED" ? 401 : 503 },
);
return auth.response;
}
let body: Record<string, unknown>;
@@ -71,9 +60,17 @@ export async function POST(req: NextRequest) {
expiresAt,
} = body;
if (typeof clientId !== "string" || typeof name !== "string" || !clientId.trim() || !name.trim()) {
if (
typeof clientId !== "string" ||
typeof name !== "string" ||
!clientId.trim() ||
!name.trim()
) {
return NextResponse.json(
{ error: "clientId and name are required strings", code: "VALIDATION_ERROR" },
{
error: "clientId and name are required strings",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -87,17 +84,32 @@ export async function POST(req: NextRequest) {
}
const parsedRateLimit = rateLimit === undefined ? 100 : Number(rateLimit);
if (!Number.isInteger(parsedRateLimit) || parsedRateLimit < 1 || parsedRateLimit > 100000) {
if (
!Number.isInteger(parsedRateLimit) ||
parsedRateLimit < 1 ||
parsedRateLimit > 100000
) {
return NextResponse.json(
{ error: "rateLimit must be an integer between 1 and 100000.", code: "VALIDATION_ERROR" },
{
error: "rateLimit must be an integer between 1 and 100000.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
const parsedQuotaMb = storageQuotaMb === undefined ? 0 : Number(storageQuotaMb);
if (!Number.isInteger(parsedQuotaMb) || parsedQuotaMb < 0 || parsedQuotaMb > 1048576) {
const parsedQuotaMb =
storageQuotaMb === undefined ? 0 : Number(storageQuotaMb);
if (
!Number.isInteger(parsedQuotaMb) ||
parsedQuotaMb < 0 ||
parsedQuotaMb > 1048576
) {
return NextResponse.json(
{ error: "storageQuotaMb must be an integer between 0 and 1048576.", code: "VALIDATION_ERROR" },
{
error: "storageQuotaMb must be an integer between 0 and 1048576.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -113,7 +125,10 @@ export async function POST(req: NextRequest) {
const ipValidation = validateAllowedIpsInput(allowedIps);
if (!ipValidation.valid) {
return NextResponse.json(
{ error: ipValidation.error || "Invalid allowedIps.", code: "VALIDATION_ERROR" },
{
error: ipValidation.error || "Invalid allowedIps.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
@@ -125,11 +140,14 @@ export async function POST(req: NextRequest) {
const expValidation = validateClientExpiresAtInput(expiresAt);
if (!expValidation.valid) {
return NextResponse.json(
{ error: expValidation.error || "Invalid expiresAt.", code: "VALIDATION_ERROR" },
{
error: expValidation.error || "Invalid expiresAt.",
code: "VALIDATION_ERROR",
},
{ status: 400 },
);
}
normalizedExpiresAt = expValidation.normalized;
normalizedExpiresAt = expValidation.iso ?? null;
}
const existing = await SDKManager.getClientAsync(safeClientId);
@@ -149,6 +167,21 @@ export async function POST(req: NextRequest) {
expiresAt: normalizedExpiresAt,
});
await recordAdminAuditLogAsync({
actorEmail: auth.auth.session.email,
actorRole: auth.auth.session.role || "owner",
action: "CLIENT_CREATED",
target: newClient.clientId,
ipAddress: extractClientIp(req),
metadata: {
name: newClient.name,
rateLimit: newClient.rateLimit,
storageQuotaMb: newClient.storageQuotaMb,
allowedIps: newClient.allowedIps,
expiresAt: newClient.expiresAt,
},
});
return NextResponse.json({ client: newClient }, { status: 201 });
} catch (err: unknown) {
const message =